Skip to content
This repository has been archived by the owner on Mar 22, 2019. It is now read-only.

Fixes issue 149 - Docs say handlebars is bundled with Ember #157

Closed
wants to merge 2 commits into from

Conversation

mattkatz
Copy link
Contributor

Should keep some folks from being confused.

@wagenet
Copy link
Member

wagenet commented Oct 20, 2012

This seems like the right direction. However, if your template is a function that returns a string (as many templating languages do) you don't need to override render you can just set it as your template. However, there's still a lot of work to be done to integrate with Ember. The ember-handlebars package evidences this.

For now, it might just be best to just say that Handlebars is the default and best integrated templating language for Ember and provide a link to the website for download.

Heh, after this I probably could have just done it myself, but I like getting others involved too. If your last name is Katz you're especially obligated to contribute :P

@wagenet
Copy link
Member

wagenet commented Oct 24, 2012

@mattkatz Is this something that you'll be able to update? I appreciate you tackling it.

@mattkatz
Copy link
Contributor Author

Yup, I'll take a stab at it.

Peter Wagenet notifications@github.com wrote:

@mattkatz Is this something that you'll be able to update? I appreciate
you tackling it.


Reply to this email directly or view it on GitHub:
#157 (comment)

Sent from a tin can with K-9 Mail. Please excuse any lingering soup smell.

Template not render, clean up language.
@mattkatz
Copy link
Contributor Author

How's that look?

@wagenet
Copy link
Member

wagenet commented Oct 26, 2012

Cherry-picked. Thanks!

@wagenet wagenet closed this Oct 26, 2012
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants