This repository has been archived by the owner on Mar 22, 2019. It is now read-only.
add community section #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@pangratz a community section sounds great. I look forward to reviewing this soon. |
|
@pangratz Unfortunately we changed up the design before I had a chance to review it. Is it possible for you to fix this up for the new design? |
|
@wagenet sure |
|
@wagenet adapted changes for new design. |
This was referenced Jan 28, 2012
nikolas
pushed a commit
to nikolas/website
that referenced
this pull request
Jan 22, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is my approach to add a community section to the website, which holds information on how to contribute to ember.js, file bugs and where to get help.
I don't know if I my adding of a section is coded as favored but it works. I know it's not good because the menu with the section is basically just a copy and paste. What is the intended way of doing this?
Also: contributions welcome! So maybe we should make the menu hidden (like the tutorial is) so we can enhance this before its made public.
This pull request adresses #8 and #9.