Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace data with envelopeData to avoid quotes in the class #553

Closed
wants to merge 1 commit into from

Conversation

priettt
Copy link
Contributor

@priettt priettt commented Mar 12, 2024

Added nameMappings in openApiGenerate to avoid the data property in Envelope looking like this:

val `data`: EnvelopeData

Copy link
Contributor Author

priettt commented Mar 12, 2024

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @priettt and the rest of your teammates on Graphite Graphite

@priettt priettt mentioned this pull request Mar 12, 2024
@priettt priettt marked this pull request as ready for review March 12, 2024 20:14
@priettt priettt requested a review from a team as a code owner March 12, 2024 20:14
@priettt priettt marked this pull request as draft March 12, 2024 20:14
Copy link

codecov bot commented Mar 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.19%. Comparing base (82e5f46) to head (bfd867a).

Additional details and impacted files

Impacted file tree graph

@@                Coverage Diff                 @@
##           openApiCodeGen     #553      +/-   ##
==================================================
+ Coverage           80.15%   80.19%   +0.03%     
==================================================
  Files                 412      412              
  Lines               10986    10986              
  Branches             1617     1617              
==================================================
+ Hits                 8806     8810       +4     
+ Misses               1535     1532       -3     
+ Partials              645      644       -1     

see 2 files with indirect coverage changes

Copy link

github-actions bot commented Jun 7, 2024

This PR is stale because it has been open 20 days with no activity. Remove stale label or comment or this PR will be closed in 10 days.

@github-actions github-actions bot added stale and removed stale labels Jun 7, 2024
@fractalwrench
Copy link
Contributor

Closing as stale

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants