Added typeMappings and languageSpecificPrimitives to avoid full imports #562
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## codegenNameMapping #562 +/- ##
======================================================
- Coverage 80.19% 80.08% -0.11%
======================================================
Files 412 412
Lines 10986 10986
Branches 1617 1617
======================================================
- Hits 8810 8798 -12
- Misses 1532 1544 +12
Partials 644 644 |
|
This PR is stale because it has been open 20 days with no activity. Remove stale label or comment or this PR will be closed in 10 days. |
|
This PR was closed due to inactivity. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added typeMappings and languageSpecificPrimitives to avoid classes with full import paths (like kotlin.String and kotlin.collections.Map)
This doesn't work with List, it's probably a problem in the generator. I tried having a look at the source code but it's a mess 😅