Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added typeMappings and languageSpecificPrimitives to avoid full imports #562

Draft
wants to merge 1 commit into
base: codegenNameMapping
Choose a base branch
from

Conversation

priettt
Copy link
Contributor

@priettt priettt commented Mar 13, 2024

Added typeMappings and languageSpecificPrimitives to avoid classes with full import paths (like kotlin.String and kotlin.collections.Map)

This doesn't work with List, it's probably a problem in the generator. I tried having a look at the source code but it's a mess 😅

@priettt priettt mentioned this pull request Mar 13, 2024
Copy link
Contributor Author

priettt commented Mar 13, 2024

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @priettt and the rest of your teammates on Graphite Graphite

@priettt priettt marked this pull request as ready for review March 13, 2024 17:11
@priettt priettt requested a review from a team as a code owner March 13, 2024 17:11
@priettt priettt marked this pull request as draft March 13, 2024 17:11
Copy link

codecov bot commented Mar 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.08%. Comparing base (bfd867a) to head (21555a6).

Additional details and impacted files

Impacted file tree graph

@@                  Coverage Diff                   @@
##           codegenNameMapping     #562      +/-   ##
======================================================
- Coverage               80.19%   80.08%   -0.11%     
======================================================
  Files                     412      412              
  Lines                   10986    10986              
  Branches                 1617     1617              
======================================================
- Hits                     8810     8798      -12     
- Misses                   1532     1544      +12     
  Partials                  644      644              

see 7 files with indirect coverage changes

Copy link

github-actions bot commented Jun 7, 2024

This PR is stale because it has been open 20 days with no activity. Remove stale label or comment or this PR will be closed in 10 days.

@github-actions github-actions bot added the stale label Jun 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant