Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove disk field #975

Merged
merged 1 commit into from
Jun 20, 2024
Merged

Conversation

fractalwrench
Copy link
Contributor

Goal

Removes the disk_space field in Resource as it's already covered by disk_total_capacity.

@fractalwrench fractalwrench requested a review from a team as a code owner June 19, 2024 13:34
Copy link

codecov bot commented Jun 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.71%. Comparing base (e2051d9) to head (ee9e16c).

Additional details and impacted files

Impacted file tree graph

@@                     Coverage Diff                      @@
##           integration/v2-migration     #975      +/-   ##
============================================================
- Coverage                     79.81%   79.71%   -0.10%     
============================================================
  Files                           406      406              
  Lines                         10815    10813       -2     
  Branches                       1720     1720              
============================================================
- Hits                           8632     8620      -12     
- Misses                         1404     1414      +10     
  Partials                        779      779              
Files Coverage Δ
...re/envelope/resource/EnvelopeResourceSourceImpl.kt 96.96% <100.00%> (-0.09%) ⬇️
...id/embracesdk/internal/payload/EnvelopeResource.kt 100.00% <100.00%> (ø)

... and 2 files with indirect coverage changes

Copy link
Collaborator

@bidetofevil bidetofevil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fractalwrench fractalwrench merged commit b405fcd into integration/v2-migration Jun 20, 2024
3 checks passed
@fractalwrench fractalwrench deleted the remove-disk-attribute branch June 20, 2024 06:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants