-
Notifications
You must be signed in to change notification settings - Fork 110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v2 fails build because config.targets given to Webpack is incorrect type #404
Comments
How can we reproduce? |
Can't imagine this works in any project... but you can definitely see it by adding it to ember-data (or bumping to it in the chore/bump-ember branch) |
@rwjblue confirmed broken for all projects, minimal reproduction is to create a new ember app, install 2.0, and run |
See the second line of the 2.0 upgrade guide:
|
We can add a better error message though. |
I can confirm that 2.0 works for me when also adding webpack >= 5. What made this confusing (or else I might have gone looking for that v2 suggestion in the upgrade guide) was that other addons (ember-qunit, ember-cli-fastboot-testing) which also use ember-auto-import v1 brought webpack 4, which resulted in the error above instead of an error for missing webpack (or wrong webpack version). |
Together, |
Just faced this issue with "ember-auto-import": "^2.0.1",
|
#414 should make this problem more obvious. |
This is being set to a string that is none of these values here: https://github.com/ef4/ember-auto-import/blob/dfd511c104307918500b1d861e87c6a63853d458/packages/ember-auto-import/ts/webpack.ts#L153-L156
The text was updated successfully, but these errors were encountered: