Addon upgrade #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@lifeart for auto-import 2.x you need web pack 5 as a peer dep. It's in the readme and in the migration guide but I'd missed that when I bumped, this is why that issue was closed. |
|
@runspired should addon blueprint to be updated? As I understand, 3.26 version has devDependency on auto-impot 2, but webpack 5 is not mentioned, and it may be hard to track down thing for developers not familiar with details (because issue bubbling up right after ember-cli-update usage for addon) |
|
ah, looks like blueprint use older version - https://github.com/ember-cli/ember-addon-output/blob/master/package.json#L40, but issue will be valid once bumped |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
removed ember-auto-import dependency because of this fail: embroider-build/ember-auto-import#404 (comment)
also, updated addon blueprint