Address misleading warnings from rollup about externals #1015
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When building a v2 addon we deliberately *don't* want rollup to do anything with imports of our dependencies or the various ember-provided package names we might refer to. And that is what already happens, except rollup emits warnings about them. This adds a plugin that handles these dependenices correctly, making them explicitly as external so there's no warning, while ensuring that if you stray from the allowed resolvable dependencies you will still see warnings.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When building a v2 addon we deliberately don't want rollup to do anything with imports of our dependencies or the various ember-provided package names we might refer to. And that is what already happens, except rollup emits warnings about them.
This adds a plugin that handles these dependenices correctly, making them explicitly as external so there's no warning, while ensuring that if you stray from the allowed resolvable dependencies you will still see warnings.