Per route code splitting #109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It seems pretty niche that you'd want to turn it off, and those people should just fix their stuff (like stop using custom serialize hooks) before trying to do route splitting.
|
I'm anxious to see Ember Engines + Embroider thank you so much @ef4 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This introduces the
splitAtRoutesoption. It lets you choose whatever set of routes you'd like to be split points, and it splits them and their children into lazily loaded bundles.It also introduces the
@embroider/routerpackage, which is a very small extension to the stock Ember router that causes it to notice the existence of these lazy bundles and load them at the appropriate time.