Don't rely on htmlbars internals #1743
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I'm working on a cleanup in ember-cli-htmlbars that is blocked on embroider touching some internals.
ef4
force-pushed
the
htmlbars-cleanup
branch
from
1af0206
to
7651407
Compare
| } | ||
| export default function loadAstPlugins(registry: any): Transform[] { | ||
| let plugins = registry.load('htmlbars-ast-plugin').map((wrapper: any) => wrapper.plugin); | ||
| plugins.reverse(); |
There was a problem hiding this comment.
why's the reverse needed?
There was a problem hiding this comment.
The plugins in the registry have historically always run in the backwards order for dumb reasons. sigh.
I should make sure the comment doesn't get dropped by this PR though, if you look through the diff you can see the spot where it's getting removed.
ef4
added a commit
to ember-cli/ember-cli-htmlbars
that referenced
this pull request
Dec 23, 2023
won't actually pass until embroider-build/embroider#1743
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm working on a cleanup in ember-cli-htmlbars that is blocked on embroider touching some internals.