Refactor the resolve function to be the only public api to module-resolver

[mansona]

No description provided.

[void-mAlex]

any chance this refactor could land on stable first? I'd like to have one api to call from the code mod and not support maybe Promises maybe sync style nodeResolve

[mansona]

any chance this refactor could land on stable first?

To be honest, that's quite unlikely 😞 This is in the class of things where it could potentially break things but has very little gain to people who are not using Vite, and is the main reason why we forked stable from main.

I'd like to have one api to call from the code mod

I mean... I don't see any reason why you need to use stable for the codemod 🤔 why not use unstable?

[void-mAlex]

I mean... I don't see any reason why you need to use stable for the codemod 🤔 why not use unstable?

because I want to use the codemod and I use stable :)

also it's more reasonable to give it to people who can't get to main and this could be the push/unblocker to get them there

[ef4]

This is getting close. The remaining failure is in the vite-specific test, because as of this change we use the real esbuild and vite resolvers instead of the node resolver when locating components, and that is causing some trouble.

• vite has a plugin during depscan that turns "not found" into "external" so it will be silently ignored by esbuild. But this is bad for us because when we're checking "does this file exist?" we want honest answers, rather than always getting "yes (but external)". It's probably OK to always treat external as not_found, at least during depscan.
• we're also running into the dreaded Packages using self-referencing imports will fail to resolve ("moduleResolution": "node16" and package.json "exports") vitejs/vite#9731 because now component resolution uses the real vite resolver and the vite resolver is wrong for self-references in v2 addons (v1 addons get adjusted automatically by embroider to handle self-references, v2 addons are able to use the full package.json exports API and are supposed to be able to rely on it)

[NullVoxPopuli]

nevermind

v2 addons are able to use the full package.json exports API and are supposed to be able to rely on it)

in my testing, this has only been true when type: module
demo here:

demo

Maybe i've been confusing actual modules with not-quite-modules (js with no type=module)

at least now we have a demo proving that self-imports are supposed to work 😅

[ef4]

The remaining failure here seems to be because our esbuild external-to-not-found workaround is too broad. It's causing a dep like qunit to be reported as not_found, when I think vite is telling esbuild that's it's external during depscan.