vite: fix hbs loading for virtual pair components #1813
Conversation
|
This is likely going to be solved as part of #1794, we literally just hit a similar error |
|
@mansona i think that will fix a specific issue. But not the filter. I think the filter is not good. |
patricklx
force-pushed
the
fix-hbs-filter
branch
3 times, most recently
from
1e33bc3
to
59b42eb
Compare
patricklx
force-pushed
the
fix-hbs-filter
branch
from
634b4f0
to
9c880bb
Compare
|
first error https://github.com/embroider-build/embroider/actions/runs/8252373750/job/22571786702?pr=1813#step:4:259 second: |
patricklx
force-pushed
the
fix-hbs-filter
branch
from
7bc2c27
to
c11bfac
Compare
patricklx
force-pushed
the
fix-hbs-filter
branch
from
c11bfac
to
d7e9625
Compare
| templateResolution.id = resolvedId; | ||
|
|
||
| const pkg = resolverLoader.resolver.packageCache.ownerOfFile(resolvedId); | ||
| const isInComponents = pkg?.isV2App() && resolvedId.slice(pkg?.root.length).startsWith('/components'); |
There was a problem hiding this comment.
this will always be false for addons, which is good, because they should not do template colocation / template-only.
It's already done in previous stage
mansona
changed the title
There was a problem hiding this comment.
This looks good 👍 myself and @ef4 reviewed it this morning and we're happy to get it merged. I added a commit to reset the hbs extension handling to use createFilter again, but tests pass and I'm happy that it's doing the same thing
it happens when embroider generates a virtual pair component, the resolved id then looks like
/template.hbs/component.ts-embroider-pair-component