Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor suite-setup-util to avoid knock on errors. #697

Merged

Commits on Mar 1, 2021

  1. Refactor suite-setup-util to avoid knock on errors.

    This is a small refactor that does a few things:
    
    * migrate the manual promise chaining to async/await
    * unify the error handling (so that it is all done in the same way)
    * migrate from `process.stderr.write` to `console.error`
      (`process.stderr.write` only accepts a string or buffer, if you pass
      it an instance of `Error` you get an error that actually masks the
      _real_ error)
    * migrate to `process.exitCode` instead of `process.exit` (forcing exit
      with `process.exit()` _in general_ should be avoided, and doesn't seem
      required in this context)
    rwjblue committed Mar 1, 2021
    Configuration menu
    Copy the full SHA
    50153f4 View commit details
    Browse the repository at this point in the history