TemplateCompiler fixes / improvements (avoid monkey patch for Ember 3.27+) #700
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* extract a helper for introspecting ember version from the source comment * makes it clearer what changes are needed for each Ember version
New API exposed in emberjs/ember.js#19426 enables us to avoid munging with the template compiler internals.
`registerPlugin` / `unregisterPlugin` have been deprecated (they rely on global mutation, and are slated for removal in Ember 4.0).
This does two main things: * removes processing of HTML entities * disables Handlebars whitespace removal for certain contexts These changes are important because it allows our source -> source transformation to remain stable in more circumstances.
This API was introduced in emberjs/ember.js#19426 and allows us to avoid Ember's own AST transform plugins. The changes here are safe across all Ember version ranges (in both cases applyTransforms avoids running Ember's own transforms).
|
Nice, thanks! |
This was referenced Mar 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At a high level this PR does a few things:
vm.createContextto prevent global mutation during template compiler evaluationregisterPlugintemplate compiler API (we were not using it)TemplateCompiler#applyTransformsto be safer for source -> source transformations (e.g. preserving entity encoding)