Remove ember-cli-htmlbars dependency in @embroider/compat.
#706
Conversation
rwjblue
changed the title
ember-cli-htmlbars dependency in @embroider/compat.
rwjblue
force-pushed
the
remove-ember-cli-htmlbars-dep
branch
from
d67ddb8
to
6ea80b7
Compare
|
Just to note the status here for anyone else stumbling by, this PR is not quite correct. There are tests in |
We still need `ember-cli-htmlbars@3` for tests (specifically to ensure that inline precompilation works still in that mode), but we definitely do not need to ship this dependency to our consumers. The only import we had for `ember-cli-htmlbars` itself was specifically for types, which we define internally (in `types/ember-cli-htmlbars/index.d.ts`).
rwjblue
force-pushed
the
remove-ember-cli-htmlbars-dep
branch
from
6ea80b7
to
f8a9e5f
Compare
There was a problem hiding this comment.
OK, so I've gotten to the bottom of why this was passing. Apparently, removing the aliasing in packages/compat/package.json then running yarn was "not enough" to remove the alias.
I've removed the name alias from yarn.lock (it seems newer versions of yarn@1 do not preserve name if it isn't needed), confirmed tests failed properly, then brought it back.
yarn.lock
Outdated
| @@ -6832,7 +6821,18 @@ ember-cli-htmlbars-inline-precompile@^2.1.0: | |||
| heimdalljs-logger "^0.1.9" | |||
| silent-error "^1.1.0" | |||
|
|
|||
| ember-cli-htmlbars@^4.0.0, ember-cli-htmlbars@^4.0.8, ember-cli-htmlbars@^4.0.9, ember-cli-htmlbars@^4.2.0, ember-cli-htmlbars@^4.2.2, ember-cli-htmlbars@^4.2.3, ember-cli-htmlbars@^4.3.1: | |||
| ember-cli-htmlbars@^3.0.0, ember-cli-htmlbars@^3.0.1, ember-cli-htmlbars@^3.1.0: | |||
| name ember-cli-htmlbars-3 | |||
There was a problem hiding this comment.
This name alias is what is causing the tests to continue to pass. Someone in the build has ember-cli-htmlbars@3 still, and when yarn was ran after removing the alias it did not remove the name field here.
Removing this name field makes the tests properly fail.
When introduced in 48fc86b this dependency was used (by
packages/compat/src/apply-ast-transforms.ts) to import and re-use the broccoli plugin, but that code was removed in 07d3c46.The only import we had for it was specifically for types, which we define internally (in
types/ember-cli-htmlbars/index.d.ts).These dependencies do not seem to be needed anymore.