Ensure babel transpilation cache is invalided when changing versions of babel plugins or AST transforms #841
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stefanpenner
force-pushed
the
cache-busting
branch
2 times, most recently
from
a45c8ea
to
12ecbc1
Compare
Ensure we include the package’s version in the configuration, so that the babel-loader can detect module version changes in it’s cache key consideration. Without this, installing a new node_module may not result in babel-loaders cache expiration occurring.
stefanpenner
force-pushed
the
cache-busting
branch
from
03d5d12
to
60dc72d
Compare
stefanpenner
commented
Jun 9, 2021
stefanpenner
commented
Jun 9, 2021
| @@ -144,6 +145,36 @@ export function excludeDotFiles(files: string[]) { | |||
| return files.filter(file => !file.startsWith('.') && !file.includes('/.')); | |||
| } | |||
|
|
|||
| export const CACHE_BUSTING_PLUGIN = { | |||
There was a problem hiding this comment.
this fixes (2)
stefanpenner
commented
Jun 9, 2021
| useMethod?: string; | ||
| } | ||
|
|
||
| const { findUpPackagePath } = resolvePackagePath; | ||
|
|
||
| export function maybeNodeModuleVersion(path: string) { |
stefanpenner
force-pushed
the
cache-busting
branch
2 times, most recently
from
9295005
to
3eb7828
Compare
stefanpenner
commented
Jun 10, 2021
stefanpenner
commented
Jun 10, 2021
stefanpenner
force-pushed
the
cache-busting
branch
from
3eb7828
to
8915809
Compare
rwjblue
requested changes
Jun 10, 2021
rwjblue
reviewed
Jun 10, 2021
stefanpenner
force-pushed
the
cache-busting
branch
3 times, most recently
from
6dddcda
to
fad8137
Compare
We could add another CI worker to run sequential ember-try scenarios... but it's unclear we can just continue to add those CI jobs... if we want to do that sure, otherwise I think this is adequate given our current priorities. |
Probably. I think we should likely also include targets info, though it may already be included (since its probably part of options to |
I believe these are in there already |
|
@rwjblue with a fresh mind tomorrow I’ll think about approaches to do a more e2e test that is the right cost/benefit. |
rwjblue
reviewed
Jun 11, 2021
Today, babel’s caches (via babel-loader today) expires caches only if the options passed to it change, unfortunately if you upgrade a plugin without changing the configuration options and the file contents remains the same, the cache will not be evicted. This can lead to spurious caching problems if the associated plugins behavior has changed. To address this defect we now include (when available) the package.json#version of the babel plugins used in our own no-op babel plugin’s configuration. This new no-op plugin is then inserted at the end of the configuration in question.
stefanpenner
force-pushed
the
cache-busting
branch
from
c6ddb9c
to
e988688
Compare
rwjblue
changed the title
rwjblue
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This includes 2 fixes:
Ensure we include the package’s version in the configuration, so that the babel-loader can detect module version changes in it’s cache key consideration. Without this, installing a new node_module may not result in babel-loaders cache expiration occurring.
We now ensure a given plugins node_module version is included (when available) in the babel configuration. Which ensures the cache is correctly evicted. This is accomplished by adding our own noop babel plugin into the plugin configuration, and having it contain the various plugin path / version pairs.