Convert engines-host-app to new test structure #854
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Additionally introduces a new way to apply diffs via fixtures which keeps the test files smaller and cleaner
thoov
changed the title
The path returned from globby always contains / so sep on windows is not found inside of the path.
also fix release manifest glob
rwjblue
approved these changes
Jun 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Once this PR lands we can remove the following "old" tests:
I did not want to remove them in this PR as it would be very large. Additionally this PR introduces a new way to apply diffs via fixtures which helps keeps the test scenario files smaller and cleaner.
This is the main file in this PR: https://github.com/embroider-build/embroider/blob/0916240fa413322666243a7ef93994bd6402211c/tests/scenarios/engines-test.ts