Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert sample-lib to new test infra #874

Merged
merged 3 commits into from
Jun 24, 2021
Merged

Convert sample-lib to new test infra #874

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
bf6e109
Convert sample-lib to new infra
thoov Jun 24, 2021
cabf0b8
dont change double test
thoov Jun 24, 2021
9bbbfd6
add back test title
thoov Jun 24, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
3 changes: 0 additions & 3 deletions test-packages/sample-lib/index.js
View file
Open in desktop

This file was deleted.

5 changes: 0 additions & 5 deletions test-packages/sample-lib/package.json
View file
Open in desktop

This file was deleted.

11 changes: 9 additions & 2 deletions tests/scenarios/fastboot-app-test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,13 +1,20 @@
import { appScenarios } from './scenarios';
import { PreparedApp } from 'scenario-tester';
import { PreparedApp, Project } from 'scenario-tester';
import { setupFastboot } from './helpers';
import QUnit from 'qunit';
import merge from 'lodash/merge';
const { module: Qmodule, test } = QUnit;

appScenarios
.map('dynamic-import', project => {
project.linkDependency('@embroider/sample-lib', { baseDir: __dirname });
let sampleLib = new Project('@embroider/sample-lib', '0.0.0');
merge(sampleLib.files, {
'index.js': `export default function () {
return 'From sample-lib';
}`,
});

project.addDependency(sampleLib);
project.linkDependency('ember-cli-fastboot', { baseDir: __dirname });
project.linkDependency('fastboot', { baseDir: __dirname });
project.linkDependency('fastboot-addon', { baseDir: __dirname });
Expand Down
1 change: 0 additions & 1 deletion tests/scenarios/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,6 @@
},
"license": "MIT",
"devDependencies": {
"@embroider/sample-lib": "link:../../test-packages/sample-lib",
"@embroider/macros": "0.42.2",
"bootstrap": "^4.3.1",
"broccoli-funnel": "^3.0.5",
Expand Down
3 changes: 0 additions & 3 deletions yarn.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1311,9 +1311,6 @@
resolve "^1.8.1"
semver "^7.3.2"

"@embroider/sample-lib@link:test-packages/sample-lib":
version "0.0.0"

"@embroider/shared-internals@0.41.0":
version "0.41.0"
resolved "https://registry.yarnpkg.com/@embroider/shared-internals/-/shared-internals-0.41.0.tgz#2553f026d4f48ea1fd11235501feb63bf49fa306"
Expand Down