Fix race condition finding the owning package of a given file when using multiple workers #881
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lifeart
approved these changes
Jun 29, 2021
rwjblue
approved these changes
Jun 29, 2021
rwjblue
changed the title
|
woohoo! |
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PackageCache'sownerOfFilecan give the wrong result when dealing with in-repo nested package structures (like a dummy app, in-repo-addon, or runtime fastboot directory) such that there is no interveningnode_modulesfolder between the parent and child packages.It only happens if there's a request for the parent package before the files in the child package, which is why this was a sporadic race that only happened sometimes, when running with multiple parallel workers where the order is nondeterministic.