Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use @ember/test-waiters in @embroider/router #929

Merged
merged 1 commit into from
Aug 21, 2021

Conversation

mydea
Copy link
Contributor

@mydea mydea commented Aug 20, 2021

Currently, @embroider/router imports directly from @ember/test, which triggers the following runtime error for me when trying to run my app:

Uncaught Error: Attempted to use test utilities, but `ember-testing` was not included
    at testingNotAvailableMessage (webpack-internal:///./node_modules/ember-source/@ember/test/index.js:30)
    at Router.init (webpack-internal:///./node_modules/@embroider/router/index.js:119)
    at Router.superWrapper [as init] (webpack-internal:///./node_modules/ember-source/@ember/-internals/utils/index.js:445)
    at initialize (webpack-internal:///./node_modules/ember-source/@ember/-internals/runtime/lib/system/core_object.js:165)
    at Function.create (webpack-internal:///./node_modules/ember-source/@ember/-internals/runtime/lib/system/core_object.js:697)
    at FactoryManager.create (webpack-internal:///./node_modules/ember-source/@ember/-internals/container/index.js:535)
    at Proxy.create (webpack-internal:///./node_modules/ember-source/@ember/-internals/container/index.js:250)
    at instantiateFactory (webpack-internal:///./node_modules/ember-source/@ember/-internals/container/index.js:351)
    at lookup (webpack-internal:///./node_modules/ember-source/@ember/-internals/container/index.js:279)
    at Container.lookup (webpack-internal:///./node_modules/ember-source/@ember/-internals/container/index.js:146)

This PR adds @ember/test-waiters as a dependency to @embroider/router and uses it instead of registerWaiter.

@ef4
Copy link
Contributor

ef4 commented Aug 21, 2021

Thanks, looks good!

@ef4 ef4 merged commit 7715504 into embroider-build:master Aug 21, 2021
@rwjblue rwjblue added the bug Something isn't working label Aug 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants