chore: improve package json typings #955
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
lifeart
commented
Aug 31, 2021
•
lifeart
commented
- in addition, fixed keywords field for synthetic packages
- AddonMeta properties merging
lifeart
commented
Aug 31, 2021
| name: '@embroider/synthesized-vendor', | ||
| version: '0.0.0', | ||
| keywords: 'ember-addon', | ||
| keywords: ['ember-addon'], |
lifeart
commented
Aug 31, 2021
| name: '@embroider/synthesized-styles', | ||
| version: '0.0.0', | ||
| keywords: 'ember-addon', | ||
| keywords: ['ember-addon'], |
lifeart
commented
Aug 31, 2021
| | AddonMeta | ||
| | AppMeta | ||
| | { | ||
| main?: string; |
There was a problem hiding this comment.
I'm not confident about v1 version structure here
lifeart
force-pushed
the
improve-package.json-typings
branch
from
16e1384
to
2845d21
Compare
lifeart
commented
Sep 1, 2021
| @@ -288,7 +288,7 @@ export default class V1Addon { | |||
| // shallow copy only! This is OK as long as we're only changing top-level | |||
| // keys in this method | |||
| let pkg = Object.assign({}, this.packageJSON); | |||
| let meta: AddonMeta = Object.assign({}, pkg.meta, this.packageMeta); | |||
| let meta: AddonMeta = Object.assign({}, this.packageCache.get(this.root).meta, this.packageMeta); | |||
There was a problem hiding this comment.
fixed one more case here, looks like meta exists on Package class, not package.json payload
lifeart
force-pushed
the
improve-package.json-typings
branch
from
b9d5e8b
to
b0b8dbe
Compare
also fixed few error, finding by type-checking improve addonInstance typings fix more typing errors fix more typings suspend overload error here
lifeart
force-pushed
the
improve-package.json-typings
branch
from
340d42d
to
6cb360f
Compare
stefanpenner
approved these changes
Sep 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.