Upgrade ember-cli to latest throughout test infrastructure

[stefanpenner]

No description provided.

[stefanpenner]

Failures appear related to engines.

[stefanpenner]

Oh boy, the failure here is juicy!

---

TL;DR embroider's test-setup has never worked correctly, and regularly mixes multiple ember-cli versions in it's test scenario node_module tree. In this case, we have:

project has the following (relevant) dependency links:

• ember-cli -> linked to a specific ember-cli@3.16 (per test scenario)
• ember-engines -> the default ember-engines residing at embroider/node_modules/ember-engines/index.js
• ember-engines -> ember-cli (resolved from embroider/node_modules/ember-engines/index.js, which is ~3.28)

This hasn't manifested before, because the relevant code in ember-cli hasn't changed recently, now that it has it has exposed the issue.

The fact the engines (and other) dependencies introduce a dependency cycle is problematic in general, given that ember-engines is essentially frozen and that embroider aims to replace it, means a work-around in this project is likely the most appropriate.

Given this, I believe the solution is to have fixture ember-engine dependencies which correctly link the given scenarios ember-cli's version

[ef4]

I think the above commit fixes the peerDeps problem. It's not ready to merge until we get stable releases of fixturify-project and scenario-tester, after stefanpenner/node-fixturify-project#50 is reviewed and released. This is pointing at my own alpha releases just to test it.

[stefanpenner]

@ef4 I'm assuming you are looking into the failures:

   Error: ENOENT: no such file or directory, copyfile 'D:/a/embroider/embroider/packages/compat/src//add-to-tree.d.ts' -> 'C:\Users\RUNNER~1\AppData\Local\Temp\tmp-1716qQfSHqG6WFKD\node_modules\@embroider\compat\src\add-to-tree.d.ts'
        at Object.copyFileSync (fs.js:1991:3)
        at Project.hardLinkFile (D:\a\embroider\embroider\node_modules\scenario-tester\node_modules\fixturify-project\index.js:260:12)
        at Project.hardLinkContents (D:\a\embroider\embroider\node_modules\scenario-tester\node_modules\fixturify-project\index.js:243:22)
        at Project.hardLinkContents (D:\a\embroider\embroider\node_modules\scenario-tester\node_modules\fixturify-project\index.js:240:22)
        at Project.writeLinkedPackage (D:\a\embroider\embroider\node_modules\scenario-tester\node_modules\fixturify-project\index.js:221:14)
        

[stefanpenner]

LGTM