CSV parser plugin supports non-quoted values which contains " #248
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change includes 3 changes: * CSV parser supports null to `quote` and `escape` options. It means disabling quoting or escaping. * CSV guess plugin uses `quote: null` if some values contain '"' in middle of non-quoted string. * CSV parser assumes `quote: ''` (or `escape: ''`) mean disabling quoting (or escaping). This is backward incompatible because previous behavior was assuming quote='"' (or escape="\\").
|
I added another commit to make the behavior backward compatible. |
|
👍 |
|
squashed & merged: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change includes 3 changes:
quoteandescapeoptions. It meansdisabling quoting or escaping.
quote: nullif some values contain '"' inmiddle of non-quoted string.
CSV parser assumesquote: ''(orescape: '') mean disablingquoting (or escaping). This is backward incompatible because previous
behavior was assuming quote='"' (or escape="")