Updated ScaleIO driver for dynamic storage pools #267
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clintkitson
force-pushed
the
feature/scaleio_add_volumetype
branch
from
278a456
to
9004f7a
Compare
|
Testing this further. |
clintkitson
force-pushed
the
feature/scaleio_add_volumetype
branch
from
9004f7a
to
63a7b78
Compare
|
This is ready to merge upon successful tests. |
| func (d *driver) thinOrThick() string { | ||
| thinOrThick := d.r.Config.GetString("scaleio.thinOrThick") | ||
| if thinOrThick == "" { | ||
| return "ThinProvisioned" |
There was a problem hiding this comment.
Hi @clintonskitson,
I'd suggest this as an alternative:
type ScaleioProvisionType int
const (
Thin ScaleioProvisionType = iota
Thick
)This avoids free-text in many places, other than parsing it from the CLI.
|
@akutz Hmm.. having a hard time consuming this one as to the benefit. Seems like an extra layer of conversion considering it is leaving as a string into |
|
Hi @clintonskitson, Eh, you're probably right. |
|
Hi @clintonskitson, This LGTM. It just needs to be merged/rebased with/on master so I can merge it. |
This commit introduces an update that allows multiple storage pools to be used outside of configuring them in the global configuration. The volumeType parameter represents the storage pool name. * Storage Pool and Protection domain now returned by name * Storage Pool is now volumetype parameter * Updated documentation
clintkitson
force-pushed
the
feature/scaleio_add_volumetype
branch
from
63a7b78
to
282c67d
Compare
|
@akutz Rebased. |
akutz
added a commit
that referenced
this pull request
Feb 4, 2016
…etype Updated ScaleIO driver for dynamic storage pools
akutz
added a commit
to akutz/rexray
that referenced
this pull request
Mar 4, 2016
This patch marks the release of REX-Ray 0.3.2! NEW FEATURES * Support for Docker 1.10 and Volume Plugin Interface 1.2 rexray#273 * Stale PID File Prevents Service Start rexray#258 * Module/Personality Support rexray#275 * Isilon Preemption rexray#231 * Isilon Snapshots rexray#260 * boot2Docker Support rexray#263 * ScaleIO Dynamic Storage Pool Support rexray#267 ENHANCEMENTS * Improved installation documentation rexray#331 * ScaleIO volume name limitation rexray#304 * Docker cache volumes for path operations rexray#306 * Config file validation rexray#312 * Better logging rexray#296 * Documentation Updates rexray#285 BUG FIXES * Fixes issue with daemon process getting cleaned as part of SystemD Cgroup rexray#327 * Fixes regression in 0.3.2 RC3/RC4 resulting in no log file rexray#319 * Fixes no volumes returned on empty list rexray#322 * Fixes "Unsupported FS" when mounting/unmounting with EC2 rexray#321 * ScaleIO re-authentication issue rexray#303 * Docker XtremIO create volume issue rexray#307 * Service status is reported correctly rexray#310 UPDATES * <del>Go 1.6 rexray#308</del> THANK YOU * Dan Forrest * Kapil Jain * Alex Kamalov
akutz
added a commit
to akutz/rexray
that referenced
this pull request
Jul 24, 2017
Fix Issues with Glide and Version Discovery
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit introduces an update that allows multiple storage
pools to be used outside of configuring them in the global
configuration. The volumeType parameter represents the storage
pool name