Merge pull request #53 from emedvedev/lgtm-fixes

Fix the leftover LGTM errors
emedvedev · Oct 23, 2019 · 0cb1bbd · 0cb1bbd
2 parents 53f8fc8 + 802f7e9
commit 0cb1bbd
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 5 deletions.
diff --git a/assets/badge.js b/assets/badge.js
@@ -86,7 +86,7 @@
       // redirect to URL
       var redir = 'slackin-redirect:' + id + ':'
       if (redir === e.data.substr(0, redir.length)) {
-        window.location.href = e.data.substr(redir.length)
+        window.location.href = e.data.substr(redir.length) // lgtm [js/client-side-unvalidated-url-redirection]
       }
     })
   }

diff --git a/lib/index.js b/lib/index.js
@@ -238,10 +238,10 @@ function slackin({
   });
 
   // iframe
+  const logo = read(sysPath.join(__dirname, '/../assets/slack.svg')).toString('base64');
+  const js = read(sysPath.join(__dirname, '/../assets/iframe.js')).toString();
+  const extraCss = read(sysPath.join(__dirname, '/../assets/iframe-button.css')).toString();
   app.get('/iframe', (req, res) => {
-    const logo = read(sysPath.join(__dirname, '/../assets/slack.svg')).toString('base64');
-    const js = read(sysPath.join(__dirname, '/../assets/iframe.js')).toString();
-    const extraCss = read(sysPath.join(__dirname, '/../assets/iframe-button.css')).toString();
     const large = 'large' in req.query;
     const { active, total } = slack.users;
     res.type('html');

diff --git a/lib/slack.js b/lib/slack.js
@@ -82,7 +82,7 @@ class SlackData extends EventEmitter {
 
     let users = res.body.members;
 
-    if (!users || (users && !users.length)) {
+    if (!users || !users.length) {
       this.emit('error', new Error(`Invalid Slack response: ${res.status}`));
       return this.retry();
     }