alc and gex header fix #10
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
redhog
requested changes
May 3, 2022
| @@ -142,13 +142,14 @@ def _un_split_layer_columns(data): | |||
|
|
|||
| def _dump(data, file, alcfile=None): | |||
| df = _un_split_layer_columns(data) | |||
| for key, value in data['model_info'].items(): | |||
There was a problem hiding this comment.
I'd propose adding separate argument skip_header or somesuch, as this throws away info in a non-obvious way?
| @@ -27,10 +37,19 @@ def is_supported_field(fieldname): | |||
| def _dump(xyz, f, columns=None): | |||
| if columns is None: | |||
| columns = xyz["file_meta"]["columns"] | |||
| else: | |||
There was a problem hiding this comment.
Maybe split this into a separate function?
columns = clean_column_names(columns)
|
A bit sceptical to including 9999 verbatim as a NaN value... Isn't this specified in a header in many xyz files? Possibly better to filter in the dataframe rather than in parsing maybe? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Did some minor modifications, so that Aarhus Workbench can read the xyz-data and alc-file written with libaarhus.dump(...)
Might be a bit ugly but is working. Feel free to change the coding to be more "pythonic" ;-).
Did the following modifications:
Gate_Ch01_45notGate_Ch01_[44].Gate_Ch01_01instead ofGate_Ch01_[00]).data['model_info']must be skipped and not written to file.