Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support ALL criteria in SEARCH #330

Merged
merged 1 commit into from
Jan 5, 2020
Merged

Conversation

arnisoph
Copy link

@arnisoph arnisoph commented Jan 5, 2020

Signed-off-by: Arnold Bechtoldt arnold.bechtoldt@inovex.de

criteria := imap.NewSearchCriteria()
c.UidSearch(criteria) // returns: []  Error in IMAP command UID SEARCH: Missing search parameters (0.001 + 0.000 secs).

Current behaviour:

Z12hwA EXAMINE INBOX
* FLAGS (\Answered \Flagged \Deleted \Seen \Draft)
* OK [PERMANENTFLAGS ()] Read-only mailbox.
* 6 EXISTS
* 6 RECENT
* OK [UNSEEN 1] First unseen.
* OK [UIDVALIDITY 1578248986] UIDs valid
* OK [UIDNEXT 7] Predicted next UID
Z12hwA OK [READ-ONLY] Examine completed (0.001 + 0.000 secs).
hw_TVQ UID SEARCH CHARSET UTF-8
hw_TVQ BAD Error in IMAP command UID SEARCH: Missing search parameters (0.001 + 0.000 secs).
IximMg LOGOUT
* BYE Logging out
IximMg OK Logout completed (0.001 + 0.000 secs).

@codecov
Copy link

codecov bot commented Jan 5, 2020

Codecov Report

Merging #330 into master will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #330      +/-   ##
=========================================
+ Coverage   73.39%   73.4%   +0.01%     
=========================================
  Files          32      32              
  Lines        3514    3516       +2     
=========================================
+ Hits         2579    2581       +2     
  Misses        642     642              
  Partials      293     293
Impacted Files Coverage Δ
client/cmd_selected.go 73.17% <ø> (ø) ⬆️
search.go 62.12% <100%> (+0.32%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 55c8f18...6dd61a9. Read the comment docs.

search.go Outdated Show resolved Hide resolved
Signed-off-by: Arnold Bechtoldt <arnold.bechtoldt@inovex.de>
Copy link
Owner

@emersion emersion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants