Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add IDLE to capabilities list #453

Merged
merged 1 commit into from
Jan 19, 2022
Merged

Add IDLE to capabilities list #453

merged 1 commit into from
Jan 19, 2022

Conversation

sblinch
Copy link

@sblinch sblinch commented Dec 22, 2021

IDLE was changed into a built-in extension, but the default capabilities list was never updated to include it. The go-imap/client library (and probably any other sane IMAP client) resorts to polling if the IDLE cap isn't present. This PR simply adds IDLE to the list.

@emersion
Copy link
Owner

IDLE is only supported if the server implements it.

@emersion
Copy link
Owner

Hm, scratch that, we should always support it indeed.

Can you update the tests accordingly?

IDLE was changed into a built-in extension, but the default capabilities list was never updated to include it. The go-imap/client library (and probably any other sane IMAP client) resorts to polling if the IDLE cap isn't present.

Co-authored-by: sblinch <sblinch@users.noreply.github.com>
Closes emersion#453.
@foxcpp foxcpp merged commit dcd9ee6 into emersion:master Jan 19, 2022
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants