Skip to content
This repository has been archived by the owner on Mar 30, 2022. It is now read-only.

Fix 180-degree rotated buffers without Y_INVERT #79

Merged
merged 1 commit into from Nov 17, 2020
Merged

Conversation

emersion
Copy link
Owner

When the compositor sends a buffer without the Y_INVERT flag, the
resulting image had it rotated by 180 degrees.

References: swaywm/sway#5818


Not sure this is the right fix… But I tested this with all combinations of:

  • Both the Wayland and DRM backends (right now Wayland with send Y_INVERT, DRM won't)
  • Both 90-degree output rotations and flipped 90-degree output rotations

When the compositor sends a buffer without the Y_INVERT flag, the
resulting image had it rotated by 180 degrees.

References: swaywm/sway#5818
@Xyene
Copy link

Xyene commented Nov 17, 2020

I can confirm that this patch does fix the issue I was experiencing, and seems reasonable.

@emersion
Copy link
Owner Author

Alright. Let's just go with that I suppose.

@emersion emersion merged commit 2c15b09 into master Nov 17, 2020
@emersion emersion deleted the rot-no-invert branch November 17, 2020 21:12
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants