Include a systemd.service file #240

WhyNotHugo · 2020-03-10T12:57:14Z

Including (and installing) these changes triggers calls to org.freedesktop.Notifications to start a systemd user service with mako.

This is pretty much how similar daemons (eg: dunst) behave. It allows the service to be auto-started on demand, and also ties it to the graphical session.

This also makes is trivial to restart mako like any other user service, by just running systemd --user restart mako.

Users not running systemd (if that's supported) shouldn't be affected.

Including (and installing) these changes triggers calls to `org.freedesktop.Notifications` to start a systemd user service with mako. This is pretty much how similar daemons (eg: dunst) behave. It allows the service to be auto-started on demand, and also ties it to the graphical session. This also makes is trivial to restart `mako` like any other user service, by just running `systemd --user restart mako`. Users not running systemd (if that's supported) shouldn't be affected.

mako.systemd.service.in

emersion · 2020-03-10T13:22:55Z

Have you seen #188?

WhyNotHugo · 2020-03-10T14:00:04Z

@emersion Nope 🤦‍♂️

WhyNotHugo · 2020-03-10T14:07:35Z

This PR does cover your comment regarding extra steps when setting up.
Though the build system on the other one is better. I think mixing both's content is probably best.

emersion · 2020-03-10T14:40:07Z

Maybe we could use ConditionPathExists=${XDG_RUNTIME_DIR}/${WAYLAND_DISPLAY}? Does this correctly fail when WAYLAND_DISPLAY is unset?

WhyNotHugo · 2020-03-10T15:38:43Z

The actual trigger that starts his is still dbus activation. This fails the same way mako currently fails now; it fails and exits.

emersion · 2020-03-10T15:40:13Z

So systemd doesn't check for Condition* when starting a service by dbus activation?

WhyNotHugo · 2020-03-10T15:59:13Z

It doesn't look like variable expansion works on Condition*. Some preliminary testing seems to indicate that systemd doesn't support this.

emersion · 2020-03-10T16:23:24Z

systemd/systemd#15067

WhyNotHugo · 2020-03-10T16:27:07Z

In any case, this Condition* doesn't really block this PR.

Without it, the service is started upon DBus activation and fails.
With it, the service is skipped upon DBus activation and does not start.

The end result is still the same, and the difference is just under the hood (a logged service startup failure).

@gdamjan

I've incorporated these improvements from #188, by @gdamjan.

mako.systemd.service.in

emersion · 2020-03-10T16:55:44Z

@xdbob Thoughts on ExecCondition?

mako.systemd.service.in

emersion · 2020-03-10T17:13:31Z

LGTM otherwise.

emersion · 2020-03-10T17:18:24Z

One last thing: can we move this service file to contrib/, since I don't want to support any service manager in particular?

I'll merge once @xdbob gives positive feedback. :)

xdbob · 2020-03-10T18:27:55Z

I'll merge once @xdbob gives positive feedback. :)

I'll do some tests and think this through, give me a few days :)
You may also want @gdamjan opinion about these changes

emersion · 2020-03-10T18:59:31Z

No problem, we aren't in a hurry.

contrib/systemd/mako.service.in

Co-Authored-By: Дамјан Георгиевски <gdamjan@gmail.com>

xdbob

I still feel like using ExecCondition is a hack (at best a failsafe) but I don't have anything better, yet.

LGTM (but please squash the commits :) )

emersion

Alright, let's merge this. Thanks everyone!

emersion · 2020-03-14T08:51:55Z

I still feel like using ExecCondition is a hack (at best a failsafe) but I don't have anything better, yet.

You could open a systemd issue to improve this (ConditionEnv? or ConditionSessionType? or something else?).

WhyNotHugo · 2020-03-14T09:31:38Z

Thanks for all your patience! :)

gdamjan · 2020-03-14T09:57:06Z

You could open a systemd issue to improve this (ConditionEnv? or ConditionSessionType? or something else?).

ConditionSessionType seems too specific. At this point introducing wayland-session.target in upstream systemd might be the easiest thing. OTOH, that could be added to {lib}wayland or some similar package too.

xdbob · 2020-03-14T09:59:10Z

ConditionSessionType seems too specific. At this point introducing wayland-session.target in upstream systemd might be the easiest thing. OTOH, that could be added to {lib}wayland or some similar package too.

Yes, I will ask to {lib,}wayland + Xorg if systemd don't want to include the targets

emersion/mako#240

Refer to emersion/mako#240 emersion/mako#293 (comment)

markstos · 2020-11-18T18:27:15Z

mako.systemd.service.in

@@ -6,7 +6,7 @@ PartOf=graphical-session.target
 [Service]
 Type=dbus
 BusName=org.freedesktop.Notifications
-ExecCondition=/bin/sh -c '[ "$XDG_SESSION_TYPE" == "wayland" ]'
+ExecCondition=/bin/sh -c '[ -z $WAYLAND_DISPLAY ] && exit 1 || exit 0'


A cleaner way do this in systemd v246 and later is to use ConditionEnvironment=WAYLAND_DISPLAY instead.

Nice! Care to make a PR with this change?

Refer to emersion/mako#240 emersion/mako#293 (comment)

xdbob reviewed Mar 10, 2020

View reviewed changes

mako.systemd.service.in Outdated Show resolved Hide resolved

mako.systemd.service.in Outdated Show resolved Hide resolved

mako.systemd.service.in Outdated Show resolved Hide resolved

Hugo Osvaldo Barrera added 2 commits March 10, 2020 14:57

WantedBy should point to the same target as the PartOf

abf2582

Allow reloading mako via systemd

bbc5aeb

emersion mentioned this pull request Mar 10, 2020

install a systemd user service unit #188

Closed

emersion mentioned this pull request Mar 10, 2020

Add a service condition for $XDG_SESSION_TYPE systemd/systemd#15067

Closed

Hugo Osvaldo Barrera added 2 commits March 10, 2020 17:46

Improve build for systemd unit file

aad65e1

I've incorporated these improvements from #188, by @gdamjan.

Only run the systemd service if running wayland

19684f2

emersion reviewed Mar 10, 2020

View reviewed changes

mako.systemd.service.in Outdated Show resolved Hide resolved

Hugo Osvaldo Barrera added 2 commits March 10, 2020 18:06

Don't use a bashism

6c2b378

Check that WAYLAND_DISPLAY is set instead

448a3b9

emersion reviewed Mar 10, 2020

View reviewed changes

mako.systemd.service.in Outdated Show resolved Hide resolved

Simplify sh conditional

ea8d2b9

Move the systemd unit file into contrib/

ce80a68

xdbob reviewed Mar 10, 2020

View reviewed changes

contrib/systemd/mako.service.in Show resolved Hide resolved

emersion reviewed Mar 10, 2020

View reviewed changes

contrib/systemd/mako.service.in Outdated Show resolved Hide resolved

Use makoctl to reload, not mako

dfc146f

gdamjan reviewed Mar 10, 2020

View reviewed changes

contrib/systemd/mako.service.in Show resolved Hide resolved

Make sure mako runs after graphical-session.target

f803914

Co-Authored-By: Дамјан Георгиевски <gdamjan@gmail.com>

gdamjan approved these changes Mar 11, 2020

View reviewed changes

xdbob approved these changes Mar 14, 2020

View reviewed changes

emersion approved these changes Mar 14, 2020

View reviewed changes

emersion merged commit 16fbced into emersion:master Mar 14, 2020

This was referenced Mar 14, 2020

X11/Wayland specific user targets systemd/systemd#15112

Closed

Remove mako.service xdbob/sway-services#9

Closed

WhyNotHugo deleted the systemd-dbus-activation branch March 14, 2020 09:30

gdamjan added a commit to gdamjan/sway-setup that referenced this pull request Mar 14, 2020

mako now ships a systemd service file

245c116

emersion/mako#240

maximbaz mentioned this pull request Aug 3, 2020

systemd: improve ExecCondition to support absence of $WAYLAND_DISPLAY #293

Closed

ammgws added a commit to ammgws/dotfiles that referenced this pull request Oct 10, 2020

sway/mako: use upstream systemd service file

3689b3e

Refer to emersion/mako#240 emersion/mako#293 (comment)

markstos reviewed Nov 18, 2020

View reviewed changes

ammgws added a commit to ammgws/dotfiles that referenced this pull request Apr 22, 2021

sway/mako: use upstream systemd service file

beb84fa

Refer to emersion/mako#240 emersion/mako#293 (comment)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Include a systemd.service file #240

Include a systemd.service file #240

WhyNotHugo commented Mar 10, 2020

emersion commented Mar 10, 2020

WhyNotHugo commented Mar 10, 2020

WhyNotHugo commented Mar 10, 2020

emersion commented Mar 10, 2020

WhyNotHugo commented Mar 10, 2020 via email

emersion commented Mar 10, 2020

WhyNotHugo commented Mar 10, 2020

emersion commented Mar 10, 2020

WhyNotHugo commented Mar 10, 2020

emersion commented Mar 10, 2020

emersion commented Mar 10, 2020

emersion commented Mar 10, 2020

xdbob commented Mar 10, 2020

emersion commented Mar 10, 2020

xdbob left a comment

emersion left a comment

emersion commented Mar 14, 2020

WhyNotHugo commented Mar 14, 2020

gdamjan commented Mar 14, 2020

xdbob commented Mar 14, 2020

markstos Nov 18, 2020

WhyNotHugo Nov 19, 2020

markstos Nov 24, 2020

Include a systemd.service file #240

Include a systemd.service file #240

Conversation

WhyNotHugo commented Mar 10, 2020

emersion commented Mar 10, 2020

WhyNotHugo commented Mar 10, 2020

WhyNotHugo commented Mar 10, 2020

emersion commented Mar 10, 2020

WhyNotHugo commented Mar 10, 2020 via email

emersion commented Mar 10, 2020

WhyNotHugo commented Mar 10, 2020

emersion commented Mar 10, 2020

WhyNotHugo commented Mar 10, 2020

emersion commented Mar 10, 2020

emersion commented Mar 10, 2020

emersion commented Mar 10, 2020

xdbob commented Mar 10, 2020

emersion commented Mar 10, 2020

xdbob left a comment

Choose a reason for hiding this comment

emersion left a comment

Choose a reason for hiding this comment

emersion commented Mar 14, 2020

WhyNotHugo commented Mar 14, 2020

gdamjan commented Mar 14, 2020

xdbob commented Mar 14, 2020

markstos Nov 18, 2020

Choose a reason for hiding this comment

WhyNotHugo Nov 19, 2020

Choose a reason for hiding this comment

markstos Nov 24, 2020

Choose a reason for hiding this comment