Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

contrib: drop apparmor and systemd build-system integration #338

Merged
merged 2 commits into from
Feb 15, 2021

Conversation

emersion
Copy link
Owner

We get too many distribution-specific bug reports about them.

Let's not install these by default. Let's leave it to distributions to adapt and ship these.

contrib/apparmor just contains a template distributions need to
adapt.
Let's just provide a template distributions can copy.
Copy link
Collaborator

@vilhalmer vilhalmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks extremely good to me. :)

@vilhalmer vilhalmer merged commit bb7e8e4 into master Feb 15, 2021
@WhyNotHugo
Copy link
Contributor

The D-Bus service file is now broken, and should not be installed any more either (since it references the no-longer-installed-by-default systemd file).

@emersion emersion deleted the drop-contrib-stuff branch February 17, 2021 10:00
@emersion
Copy link
Owner Author

Fixed in dbd9c2b

@WhyNotHugo
Copy link
Contributor

dbd9c2b just makes everything worse.

I've put a drop-in mako.service file to run mako as a systemd service (this works before dbd9c2b). With dbd9c2b, however, mako is now started as a non-systemd service by the dbus daemon.

There's no way for me to get mako running as a systemd service any more, unless I manually edit /usr/share/dbus-1/services/fr.emersion.mako.service. However, users should not be expected to edit a system file this.

@emersion
Copy link
Owner Author

Distributions should.

@WhyNotHugo
Copy link
Contributor

WhyNotHugo commented Feb 17, 2021

So distributions now need to manually patch this file, and also install the systemd.service file, right?

Can the patch for fr.emersion.mako.service be included in contrib too? I'm just looking to avoid downstreams from having to each redo the same work (and also prevent so much fragmentation).

@emersion
Copy link
Owner Author

It's just a single line to be appended to the D-Bus service file. Maybe contrib/systemd/README with some explanations would be nice to have.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants