Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Language selector #3

Closed
emibcn opened this issue Sep 27, 2020 · 8 comments
Closed

Add Language selector #3

emibcn opened this issue Sep 27, 2020 · 8 comments
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers Hacktoberfest Simple issues suitable Hacktoberfest PRs javascript Javascript knowledge needed react React knowledge needed

Comments

@emibcn
Copy link
Owner

emibcn commented Sep 27, 2020

Let the user select his/her preferred language:

  • Language selector component could be placed directly into the menu
  • It already has a data source at App's state passed all way down to the Menu
  • If changed, all app is already translated into the selected language
@emibcn emibcn added enhancement New feature or request good first issue Good for newcomers Hacktoberfest Simple issues suitable Hacktoberfest PRs react React knowledge needed javascript Javascript knowledge needed labels Sep 27, 2020
@Abhijith126
Copy link
Contributor

can I take this?

@emibcn
Copy link
Owner Author

emibcn commented Sep 27, 2020

@Abhijith126 Of course!

@Abhijith126
Copy link
Contributor

Please feel free to assign this ticket to me. I will fork and start work on this.

@emibcn
Copy link
Owner Author

emibcn commented Sep 27, 2020

Please feel free to assign this ticket to me. I will fork and start work on this.

Done!

@Abhijith126
Copy link
Contributor

@emibcn, I have added a new Menu, Language after About.
Once selected the below dialog appears. Is this the expected behavior?
Also, how do you want to display the list of Languages?.
Let me know your thoughts on this,
image

@emibcn
Copy link
Owner Author

emibcn commented Oct 5, 2020

Looks good!

A couple of thoughts:

const keys = Object.keys(available);
keys
  // From https://www.javascripttutorial.net/array/javascript-remove-duplicates-from-array/
  .filter((key, index) => {
     return keys.indexOf(key) !== index;
  })

@Abhijith126
Copy link
Contributor

I have created a PR with the changes and added translations for words like language based on google translate. This needs to be verified.
Please check and let me know if any changes are required.

@emibcn
Copy link
Owner Author

emibcn commented Oct 9, 2020

Commented on #19 (review)

@emibcn emibcn closed this as completed in d7af4ba Oct 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers Hacktoberfest Simple issues suitable Hacktoberfest PRs javascript Javascript knowledge needed react React knowledge needed
Projects
None yet
Development

No branches or pull requests

2 participants