Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Language selection menu #19

Merged
merged 9 commits into from
Oct 9, 2020
Merged

Language selection menu #19

merged 9 commits into from
Oct 9, 2020

Conversation

Abhijith126
Copy link
Contributor

Please review this PR and let me know for any changes.
I have modified the currently available languages object into an array and did the relevant changes needed to handle the language change.

Copy link
Owner

@emibcn emibcn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it will be easier and cleare to add each language name into its own deffinition, and no need to translate them into the rest of languages. What do you think?

In the end (just before PR approval/merge), I'll make a PR against your forked repo to fix catalan ans spanish translations (my mother tongues), so they are ok before hitting master.

PS: Nice job on the Language component! 👍🏾

app/src/i18n/ca-es.lang.js Show resolved Hide resolved
app/src/i18n/available.js Outdated Show resolved Hide resolved
app/src/i18n/ca-es.lang.js Outdated Show resolved Hide resolved
@emibcn emibcn mentioned this pull request Oct 9, 2020
@Abhijith126
Copy link
Contributor Author

Please check now, I have made the changes accordingly and tested them. Should be all good.

@emibcn
Copy link
Owner

emibcn commented Oct 9, 2020

I've opened a PR against your fork to fix catalan and spanish translations. Merge it and then I'll merge the result here 👍🏾

@emibcn emibcn merged commit d7af4ba into emibcn:master Oct 9, 2020
@emibcn
Copy link
Owner

emibcn commented Oct 9, 2020

Thanked!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants