Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using local API to retrieve current track #104

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

jakub-tucek
Copy link

@jakub-tucek jakub-tucek commented Oct 1, 2018

Hey,

I made first version of changing API for retrieving current track to use local system api for spotify player as was suggested here: #103 by @patrolez.

I only tested it on Linux but clients are for the most part taken from this project:

https://github.com/panz3r/hyper-spotify/tree/master/src/lib

Please take a look and let me know what you think.

@patrolez
Copy link

patrolez commented Oct 3, 2018

I am not a TypeScript developer, but I can only say well done! 👍

It works under Linux for me also!

I wonder if @emilioastarita is still interested to maintain this repo 🤔

@Agusum
Copy link

Agusum commented Oct 4, 2018

I've tried this in macOS Mojave and it's not working for me 😢

@jakub-tucek
Copy link
Author

Thank for testing! I will take a look and see what I can do about it

@mendel3
Copy link

mendel3 commented Oct 12, 2018

Not working for me on Windows 10. In the cmd prompt, when clicking Try Again I get this
[10628:1012/232907.571:INFO:CONSOLE(6)] "Uncaught TypeError: Spotilocal is not a constructor", source: C:\Users\myles\lyricfier\render\spotify\SpotifyWindows.js (6)
I have spotify version 1.0.91.183.g259b84fa, but I also use Spicetify to customize my Spotify a bit. Could that be why this isn't working?
Thanks!

@jakub-tucek
Copy link
Author

I fixed issue on macOs Mohave so linux+macOs should work now.

Unfortunately, I had to remove support for windows as i have no idea how to do it locally. As MPRIS does not exists on windows and it seems SystemMediaTransportControls is not alternative that would allow accessing currently played track. I vote for dropping windows support until we find working alternative and in the meantime have working app for other platforms. What shall we do @emilioastarita?

@Agusum
Copy link

Agusum commented Nov 24, 2018

It works now! Thank you so much!

Is there a way you could put together a release so that it's easier to launch the app (not requiring the command line)?

@jakub-tucek
Copy link
Author

jakub-tucek commented Nov 24, 2018

Here is release in forked repo: https://github.com/jakub-tucek/lyricfier/releases/tag/v0.3.0

@mendel3
Copy link

mendel3 commented Nov 25, 2018

Is windows support a priority, because all other lyric apps for Spotify are abandoned

@wappyn
Copy link

wappyn commented Apr 2, 2021

(electron:15339): Pango-ERROR **: 22:07:44.628: Harfbuzz version too old (1.4.2)

I just done quick googling and find out that it's probably common electron problem, but I have no idea how to fix it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants