Revert "[phalcon#13208] - Interface corrections/docblocks"

This reverts commit 50792a2.
emiliodeg · Jun 20, 2019 · c66b03f · c66b03f
1 parent 50792a2
commit c66b03f
Show file tree

Hide file tree

Showing 34 changed files with 17 additions and 117 deletions.
diff --git a/phalcon/Validation/Validator.zep b/phalcon/Validation/Validator.zep
@@ -25,22 +25,19 @@ use Phalcon\Validation\ValidatorInterface;
 abstract class Validator implements ValidatorInterface
 {
     /**
-     * Message template
-     *
-     * @var string|null
-     */
+    * Message template
+    *
+    * @var string|null
+    */
     protected template;
 
     /**
-     * Message templates
-     *
-     * @var array
-     */
+    * Message templates
+    *
+    * @var array
+    */
     protected templates = [];
 
-    /**
-     * @var array
-     */
     protected options;
 
     /**

diff --git a/phalcon/Validation/Validator/Alnum.zep b/phalcon/Validation/Validator/Alnum.zep
@@ -51,9 +51,6 @@ use Phalcon\Validation\Validator;
  */
 class Alnum extends Validator
 {
-    /**
-     * @var string
-     */
     protected template = "Field :field must contain only letters and numbers";
 
     /**

diff --git a/phalcon/Validation/Validator/Alpha.zep b/phalcon/Validation/Validator/Alpha.zep
@@ -52,9 +52,6 @@ use Phalcon\Validation\Validator;
  */
 class Alpha extends Validator
 {
-    /**
-     * @var string
-     */
     protected template = "Field :field must contain only letters";
 
     /**

diff --git a/phalcon/Validation/Validator/Between.zep b/phalcon/Validation/Validator/Between.zep
@@ -63,9 +63,6 @@ use Phalcon\Validation\Validator;
  */
 class Between extends Validator
 {
-    /**
-     * @var string
-     */
     protected template = "Field :field must be within the range of :min to :max";
 
     /**

diff --git a/phalcon/Validation/Validator/Callback.zep b/phalcon/Validation/Validator/Callback.zep
@@ -62,9 +62,6 @@ use Phalcon\Validation\Validator;
  */
 class Callback extends Validator
 {
-    /**
-     * @var string
-     */
     protected template = "Field :field must match the callback function";
 
     /**

diff --git a/phalcon/Validation/Validator/Confirmation.zep b/phalcon/Validation/Validator/Confirmation.zep
@@ -58,9 +58,6 @@ use Phalcon\Validation\Validator;
  */
 class Confirmation extends Validator
 {
-    /**
-     * @var string
-     */
     protected template = "Field :field must be the same as :with";
 
     /**

diff --git a/phalcon/Validation/Validator/CreditCard.zep b/phalcon/Validation/Validator/CreditCard.zep
@@ -52,9 +52,6 @@ use Phalcon\Validation\Validator;
  */
 class CreditCard extends Validator
 {
-    /**
-     * @var string
-     */
     protected template = "Field :field is not valid for a credit card number";
 
     /**

diff --git a/phalcon/Validation/Validator/Date.zep b/phalcon/Validation/Validator/Date.zep
@@ -57,9 +57,6 @@ use Phalcon\Validation\Validator;
  */
 class Date extends Validator
 {
-    /**
-     * @var string
-     */
     protected template = "Field :field is not a valid date";
 
     /**

diff --git a/phalcon/Validation/Validator/Digit.zep b/phalcon/Validation/Validator/Digit.zep
@@ -52,9 +52,6 @@ use Phalcon\Validation\Validator;
  */
 class Digit extends Validator
 {
-    /**
-     * @var string
-     */
     protected template = "Field :field must be numeric";
 
     /**

diff --git a/phalcon/Validation/Validator/Email.zep b/phalcon/Validation/Validator/Email.zep
@@ -52,9 +52,6 @@ use Phalcon\Validation\Validator;
  */
 class Email extends Validator
 {
-    /**
-     * @var string
-     */
     protected template = "Field :field must be an email address";
     /**
      * Executes the validation

diff --git a/phalcon/Validation/Validator/ExclusionIn.zep b/phalcon/Validation/Validator/ExclusionIn.zep
@@ -64,9 +64,6 @@ use Phalcon\Validation\Exception;
  */
 class ExclusionIn extends Validator
 {
-    /**
-     * @var string
-     */
     protected template = "Field :field must not be a part of list: :domain";
 
     /**

diff --git a/phalcon/Validation/Validator/File.zep b/phalcon/Validation/Validator/File.zep
@@ -92,10 +92,7 @@ use Phalcon\Validation\Validator\File\Size\Min as MinFileSize;
  */
 class File extends ValidatorComposite
 {
-    /**
-     * @var array
-     */
-    private validators = [] { get };
+    private validators = [] {get};
 
     public function __construct(array! options = [])
     {

diff --git a/phalcon/Validation/Validator/File/FileAbstract.zep b/phalcon/Validation/Validator/File/FileAbstract.zep
@@ -59,23 +59,17 @@ abstract class FileAbstract extends Validator
 {
     /**
     * Empty is empty
-     *
-     * @var string
-     */
+    */
     protected messageFileEmpty = "Field :field must not be empty" {get, set};
 
     /**
     * File exceeed the file size setted in PHP configuration
-    *
-     * @var string
-     */
+    */
     protected messageIniSize = "File :field exceeds the maximum file size" {get, set};
 
     /**
     * File is not valid
-    *
-     * @var string
-     */
+    */
     protected messageValid = "Field :field is not valid" {get, set};
 
     /**
@@ -244,4 +238,4 @@ abstract class FileAbstract extends Validator
 
         return floatval(matches[1]) * pow(2, byteUnits[unit]);
     }
-}
+}
diff --git a/phalcon/Validation/Validator/File/MimeType.zep b/phalcon/Validation/Validator/File/MimeType.zep
@@ -66,9 +66,6 @@ use Phalcon\Validation\Validator\File\FileAbstract;
  */
 class MimeType extends FileAbstract
 {
-    /**
-     * @var string
-     */
     protected template = "File :field must be of type: :types";
 
     /**

diff --git a/phalcon/Validation/Validator/File/Resolution/Equal.zep b/phalcon/Validation/Validator/File/Resolution/Equal.zep
@@ -57,9 +57,6 @@ use Phalcon\Validation\Validator\File\FileAbstract;
  */
 class Equal extends FileAbstract
 {
-    /**
-     * @var string
-     */
     protected template = "The resolution of the field :field has to be equal :resolution";
 
     /**

diff --git a/phalcon/Validation/Validator/File/Resolution/Max.zep b/phalcon/Validation/Validator/File/Resolution/Max.zep
@@ -62,9 +62,6 @@ use Phalcon\Validation\Validator\File\FileAbstract;
  */
 class Max extends FileAbstract
 {
-    /**
-     * @var string
-     */
     protected template = "File :field exceeds the maximum resolution of :resolution";
 
     /**

diff --git a/phalcon/Validation/Validator/File/Resolution/Min.zep b/phalcon/Validation/Validator/File/Resolution/Min.zep
@@ -62,9 +62,6 @@ use Phalcon\Validation\Validator\File\FileAbstract;
  */
 class Min extends FileAbstract
 {
-    /**
-     * @var string
-     */
     protected template = "File :field can not have the minimum resolution of :resolution";
 
     /**

diff --git a/phalcon/Validation/Validator/File/Size/Equal.zep b/phalcon/Validation/Validator/File/Size/Equal.zep
@@ -63,9 +63,6 @@ use Phalcon\Validation\Validator\File\FileAbstract;
  */
 class Equal extends FileAbstract
 {
-    /**
-     * @var string
-     */
     protected template = "File :field does not have the exact :size filesize";
 
     /**

diff --git a/phalcon/Validation/Validator/File/Size/Max.zep b/phalcon/Validation/Validator/File/Size/Max.zep
@@ -63,9 +63,6 @@ use Phalcon\Validation\Validator\File\FileAbstract;
  */
 class Max extends FileAbstract
 {
-    /**
-     * @var string
-     */
     protected template = "File :field exceeds the size of :size";
 
     /**

diff --git a/phalcon/Validation/Validator/File/Size/Min.zep b/phalcon/Validation/Validator/File/Size/Min.zep
@@ -63,9 +63,6 @@ use Phalcon\Validation\Validator\File\FileAbstract;
  */
 class Min extends FileAbstract
 {
-    /**
-     * @var string
-     */
     protected template = "File :field can not have the minimum size of :size";
 
     /**

diff --git a/phalcon/Validation/Validator/Identical.zep b/phalcon/Validation/Validator/Identical.zep
@@ -57,9 +57,6 @@ use Phalcon\Validation\Validator;
  */
 class Identical extends Validator
 {
-    /**
-     * @var string
-     */
     protected template = "Field :field does not have the expected value";
 
     /**

diff --git a/phalcon/Validation/Validator/InclusionIn.zep b/phalcon/Validation/Validator/InclusionIn.zep
@@ -58,9 +58,6 @@ use Phalcon\Validation\Exception;
  */
 class InclusionIn extends Validator
 {
-    /**
-     * @var string
-     */
     protected template = "Field :field must be a part of list: :domain";
 
     /**

diff --git a/phalcon/Validation/Validator/Ip.zep b/phalcon/Validation/Validator/Ip.zep
@@ -72,9 +72,6 @@ class Ip extends Validator
     const VERSION_4  = FILTER_FLAG_IPV4;
     const VERSION_6  = FILTER_FLAG_IPV6;
 
-    /**
-     * @var string
-     */
     protected template = "Field :field must be a valid IP address";
 
     /**

diff --git a/phalcon/Validation/Validator/Numericality.zep b/phalcon/Validation/Validator/Numericality.zep
@@ -52,9 +52,6 @@ use Phalcon\Validation\Validator;
  */
 class Numericality extends Validator
 {
-    /**
-     * @var string
-     */
     protected template = "Field :field does not have a valid numeric format";
 
     /**

diff --git a/phalcon/Validation/Validator/PresenceOf.zep b/phalcon/Validation/Validator/PresenceOf.zep
@@ -52,9 +52,6 @@ use Phalcon\Validation\Validator;
  */
 class PresenceOf extends Validator
 {
-    /**
-     * @var string
-     */
     protected template = "Field :field is required";
 
     /**

diff --git a/phalcon/Validation/Validator/Regex.zep b/phalcon/Validation/Validator/Regex.zep
@@ -57,9 +57,6 @@ use Phalcon\Validation\Validator;
  */
 class Regex extends Validator
 {
-    /**
-     * @var string
-     */
     protected template = "Field :field does not match the required format";
 
     /**

diff --git a/phalcon/Validation/Validator/StringLength.zep b/phalcon/Validation/Validator/StringLength.zep
@@ -83,10 +83,7 @@ use Phalcon\Validation\Exception;
  */
 class StringLength extends ValidatorComposite
 {
-    /**
-     * @var array
-     */
-    private validators = [] { get };
+    private validators = [] {get};
 
     public function __construct(array! options = []) -> void
     {

diff --git a/phalcon/Validation/Validator/StringLength/Max.zep b/phalcon/Validation/Validator/StringLength/Max.zep
@@ -65,9 +65,6 @@ use Phalcon\Validation\Exception;
  */
 class Max extends Validator
 {
-    /**
-     * @var string
-     */
     protected template = "Field :field must not exceed :max characters long";
 
     /**

diff --git a/phalcon/Validation/Validator/StringLength/Min.zep b/phalcon/Validation/Validator/StringLength/Min.zep
@@ -65,9 +65,6 @@ use Phalcon\Validation\Exception;
  */
 class Min extends Validator
 {
-    /**
-     * @var string
-     */
     protected template = "Field :field must be at least :min characters long";
 
     /**

diff --git a/phalcon/Validation/Validator/Uniqueness.zep b/phalcon/Validation/Validator/Uniqueness.zep
@@ -93,9 +93,6 @@ use Phalcon\Mvc\Collection;
  */
 class Uniqueness extends CombinedFieldsValidator
 {
-    /**
-     * @var string
-     */
     protected template = "Field :field must be unique";
 
     private columnMap = null;

diff --git a/phalcon/Validation/Validator/Url.zep b/phalcon/Validation/Validator/Url.zep
@@ -52,9 +52,6 @@ use Phalcon\Validation\Validator;
  */
 class Url extends Validator
 {
-    /**
-     * @var string
-     */
     protected template = "Field :field must be a url";
 
     /**

diff --git a/phalcon/Validation/ValidatorComposite.zep b/phalcon/Validation/ValidatorComposite.zep
@@ -10,8 +10,6 @@
 
 namespace Phalcon\Validation;
 
-use Phalcon\Validation as BaseValidation;
-
 /**
  * Phalcon\Validation\CombinedFieldsValidator
  *
@@ -22,7 +20,7 @@ abstract class ValidatorComposite extends Validator implements ValidatorComposit
     /**
      * Executes the validation
      */
-    public function validate(<BaseValidation> validation, var field) -> bool
+    public function validate(<Validation> validation, var field) -> bool
     {
         var validator;
 

diff --git a/phalcon/Validation/ValidatorCompositeInterface.zep b/phalcon/Validation/ValidatorCompositeInterface.zep
@@ -10,8 +10,6 @@
 
 namespace Phalcon\Validation;
 
-use Phalcon\Validation as BaseValidation;
-
 /**
  * Phalcon\Validation\CombinedFieldsValidator
  *
@@ -27,5 +25,5 @@ interface ValidatorCompositeInterface
     /**
      * Executes the validation
      */
-    public function validate(<BaseValidation> validation, var field) -> bool;
+    public function validate(<Validation> validation, var field) -> bool;
 }