-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Check.sh fails to compile speech-dispatcher #1125
Comments
Have you run the setup code in https://github.com/emilk/egui#demo ( |
I'm on Arch Linux, so no |
Note that you don't need |
Also ran into this issue on Arch Linux since it ships a more recent version of |
Yeah. I could not compile it on arch too. I though something was wrong with my system. The main issue was being unable to run the CI command to check if everything was working properly. I could not use the --all-features flag as that would fail with compilation of speechd. Had to make a commit, Check why CI failed on github, fix that and repeat . It was so exhausting:( almost wanted to just install ubuntu on my old laptop just to deal with this |
A lot of people seems to be affected by this - anyone want to work on it? Either by disabling |
This is a small step in mitigating #1125
I pushed a commit that makes it easier to just disable tts when you want to test on Linux. If you apply this patch, then index 2e983d9a..3df2a370 100644
--- a/eframe/Cargo.toml
+++ b/eframe/Cargo.toml
@@ -52,7 +52,6 @@ puffin = ["dep:puffin", "egui_glow?/puffin"]
## Enable screen reader support (requires `ctx.options().screen_reader = true;`)
screen_reader = [
"egui-winit/screen_reader",
- "tts",
]
## Use [`wgpu`](https://docs.rs/wgpu) for painting (via [`egui_wgpu`](https://github.com/emilk/egui/tree/master/egui_wgpu)).
diff --git a/egui-winit/Cargo.toml b/egui-winit/Cargo.toml
index e76a399e..63fba4a7 100644
--- a/egui-winit/Cargo.toml
+++ b/egui-winit/Cargo.toml
@@ -34,7 +34,7 @@ links = ["webbrowser"]
puffin = ["dep:puffin"]
## Experimental support for a screen reader.
-screen_reader = ["tts"]
+screen_reader = []
## Allow serialization of [`WindowSettings`] using [`serde`](https://docs.rs/serde).
serde = ["egui/serde", "dep:serde"] Still unsure what a good long-term solution is. Should we just never use |
after A LOT of debugging
after the above three changes, I got no compilation errors. @emilk If you are okay with bumping min rust version and doing a |
rust 1.63 introduces a lint https://rust-lang.github.io/rust-clippy/master/index.html#derive_partial_eq_without_eq and a lot of structs in egui implement |
I'm on Nixos using the latest stable version of |
I will try making a PR tonight |
Describe the bug
check.sh fails to run ith the following compilation error
Click to expand check.sh output
To Reproduce
Steps to reproduce the behavior:
master
sh/check.sh
Expected behavior
It finishes without errors
Desktop (please complete the following information):
<-- Most likely the issue?
Additional context
Originally brought up in #1119
The text was updated successfully, but these errors were encountered: