Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump msrv 1.64 and tts + bindgen dep #2274

Merged
merged 3 commits into from
Nov 11, 2022
Merged

bump msrv 1.64 and tts + bindgen dep #2274

merged 3 commits into from
Nov 11, 2022

Conversation

coderedart
Copy link
Contributor

  • bumps msrv to 1.64 in toolchain file and workflows
  • manually bump bindgen dep using cargo update -p bindgen
  • bump tts version to latest in egui_winit and eframe crates
  • change runner image from ubuntu-latest to ubuntu-22.04

This is specifically to fix the speech-dispatcher crate compilation issues on platforms like Arch Linux.

We ended up at this PR due to the following series of events:

  1. The main issue is that workflow uses ubuntu-20.04 which has an old version of library in its repository. but other distros like Arch have the latest version which will fail to link due to breaking ABI changes.
  2. To update speech-dispatcher crate, we need to update tts crate version.
  3. latest version of speech-dispatcher crate has some issues with bindgen version 0.60, so we need to manually bump that to 0.61 (latest).
  4. bindgen latest version requires minimum version of rust to be 1.64 as it uses the std::ffi::* types .

Finally,

  • speech-dispatcher in ubuntu-latest (20.04 LTS) is version 0.9. our changes won't compile because its too old and that library had breaking changes since then.
  • speech-dispatcher in ubuntu-22.04 (will be default for ubuntu-latest by this month end) is version 0.11 and will compile successfully.

if we want to stick with ubuntu-latest, then this PR will have to wait for December i guess.

https://github.blog/changelog/2022-11-09-github-actions-ubuntu-latest-workflows-will-use-ubuntu-22-04/

Ubuntu-22.04 is ready to be the default version for the ubuntu-latest label in GitHub Actions workflows. This change will be rolled out over a period of 8 weeks beginning on October 1, 2022.

Closes #1125

clippy got a few new lints. for now, i added them to allow section of cranky.toml so that i can get this to compile for now.
I could fix those lints, but i am afraid it will touch a lot of files. If its okay to fix those lints, i can create a follow up PR to this.

I wanted to keep the noise low for this PR, so kept the changes as minimal as i could

Copy link
Owner

@emilk emilk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great!

crates/egui-winit/Cargo.toml Outdated Show resolved Hide resolved
crates/eframe/Cargo.toml Outdated Show resolved Hide resolved
coderedart and others added 2 commits November 11, 2022 14:17
Co-authored-by: Emil Ernerfeldt <emil.ernerfeldt@gmail.com>
Co-authored-by: Emil Ernerfeldt <emil.ernerfeldt@gmail.com>
@coderedart
Copy link
Contributor Author

coderedart commented Nov 11, 2022

ooh.. i can just press the commit suggestion buttom and it will add your changes without me doing anything. never knew i could do that. nice.

what about the clippy lints though?

@coderedart coderedart marked this pull request as ready for review November 11, 2022 08:48
@emilk
Copy link
Owner

emilk commented Nov 11, 2022

Let's do the clippy lints in a separate PR - I think that was a good choice

@emilk emilk merged commit 8ff1396 into emilk:master Nov 11, 2022
@coderedart coderedart deleted the msrv_bump branch November 11, 2022 12:23
emilk added a commit that referenced this pull request Dec 2, 2022
* bump msrv 1.64 and tts + bindgen dep

* Update crates/egui-winit/Cargo.toml

Co-authored-by: Emil Ernerfeldt <emil.ernerfeldt@gmail.com>

* Update crates/eframe/Cargo.toml

Co-authored-by: Emil Ernerfeldt <emil.ernerfeldt@gmail.com>

Co-authored-by: Emil Ernerfeldt <emil.ernerfeldt@gmail.com>
JohannesProgrammiert pushed a commit to JohannesProgrammiert/egui that referenced this pull request Jan 21, 2023
* bump msrv 1.64 and tts + bindgen dep

* Update crates/egui-winit/Cargo.toml

Co-authored-by: Emil Ernerfeldt <emil.ernerfeldt@gmail.com>

* Update crates/eframe/Cargo.toml

Co-authored-by: Emil Ernerfeldt <emil.ernerfeldt@gmail.com>

Co-authored-by: Emil Ernerfeldt <emil.ernerfeldt@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Check.sh fails to compile speech-dispatcher
2 participants