-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove set_enabled(true)
#4327
Comments
Good points |
The painter has a method (The doc-string of egui/crates/egui/src/painter.rs Lines 96 to 97 in 78d95f4
|
I think |
|
These were confusing, because `set_enabled(true)` and `set_visible(true)` did nothing. Instead use one of: * `ui.add_enabled`, `ui.add_enabled_ui` or `ui.disable()` * `ui.add_visible`, `ui.add_visible_ui` or `ui.set_invisible()` * Closes #4327
Is your feature request related to a problem? Please describe.
set_enabled
andset_visible
sound self explanatory to me, so I did not read the docs.I wrote
and wonder why my cooler widged is disabled.
Describe the solution you'd like
Remove (or deprecate)
ui.set_enabled(...)
andui.set_visible(...)
.Add
ui.disable()
andui.hide()
.Additional context
No clue why this design was choosen, but I think a function named
ui.set_enabled
should be able toset
theui
toenabled
.The text was updated successfully, but these errors were encountered: