Refactor common code in egui-wgpu vertex shader entry points
#1730
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Creates `unpack_color` and `position_from_screen` functions to share common logic between the alternative vertex shader entry points.
emilk
approved these changes
Jun 11, 2022
|
Yes, both entry points successfully tested with a downstream project. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Creates
unpack_colorandposition_from_screenfunctions to share common logic between the alternative vertex shader entry points. Behaviour remains the same.I noticed these when checking the difference between
vs_mainandvs_conv_mainin order to solve some breakage in colour output after updating from 0.15 to 0.18 (I'll open a separate issue/PR about this).