Update wgpu to 0.19 #3824

emilk · 2024-01-15T16:33:33Z

Closes WebGPU build broken #3675

…nsafe variant)

Cargo.toml

egui_demo_app_3.exe

crates/egui_demo_app/Cargo.toml

emilk · 2024-01-15T16:39:17Z

We should show what backend (WebGPU or WebGL) is being used in the egui_demo_app GUI

crates/eframe/Cargo.toml

emilk · 2024-01-18T09:58:49Z

glutin is locked at raw-window-handle 0.5, and wgpu at raw-window-handle 0.6. This is hell.

torokati44 · 2024-01-18T10:12:01Z

Is it still with rwh 0.6's anecdotal ability to coexist with 0.5, and convert between handles of the two versions? :/

custom_window_frame is a better demo

emilk · 2024-01-18T15:14:39Z

@Wumpf I only see the WebGL in the list of available adapters (from instance.enumerate_adapters(wgpu::Backends::all())) even in my chromium browser supporting WebGPU.

Wumpf · 2024-01-18T15:20:37Z

enumerate_adapters is too late. WebGPU is unfortunately the anomaly where the instance has to decide whether it picks WebGPU. So now the question ofc why that one is not seeing WebGPU. For that it's important to specify the right parameters for instance creation. I can have a look

Wumpf · 2024-01-18T15:25:47Z

@emilk after I finished writing the last comment I rememberd a weird anomaly I saw when testing this pr originally. Had to first double check again to confirm this. When you open the website on chrome via http://0.0.0.0:8888/ it will not work - in fact it doesn't even work from the javascript console then, you'll find that navigator.gpu is always undefined. If you however go to http://localhost:8888/ (which arguably makes more sense) it works just fine for me. Can you confirm?

emilk · 2024-01-18T15:41:49Z

Yup, that was it 🤦 so weird

crates/egui-wgpu/src/lib.rs

crates/eframe/src/web/web_painter_wgpu.rs

Co-authored-by: Mingun <Alexander_Sergey@mail.ru>

cwfitzgerald · 2024-01-21T22:35:29Z

Cargo.toml

-
-# Use this to build wgpu with WebGL support on the Web *instead* of using WebGPU.
-#wgpu = { version = "0.18.0", features = ["webgl"] }
+wgpu = { version = "0.19", features = [


I know this has already landed, but this really should be no-default-features at least for egui-wgpu

Here we go: #3875

@rustbasic

### What This is so we can test things out before the next release, and also get in some new egui features for the plot aggregator and drag-and-drop. * Closes #4716 * Closes #4794 ### TODO * [x] Fix hovering ListItems in blueprint panel ### wgpu changelog https://github.com/gfx-rs/wgpu/blob/trunk/CHANGELOG.md#v0190-2024-01-17 ### relevant egui changelog (so far) #### eframe * Keep `ViewportInfo::maximized` and `minimized` up-to-date on Windows [#3831](emilk/egui#3831) (thanks [@rustbasic](https://github.com/rustbasic)!) * Update wgpu to 0.19 [#3824](emilk/egui#3824) * Fix: handle `IconData::default()` without crashing [#3842](emilk/egui#3842) #### egui_extras * Fix unwraps in SVG scaling [#3826](emilk/egui#3826) (thanks [@amPerl](https://github.com/amPerl)!) * Update to ehttp 0.4 [#3834](emilk/egui#3834) #### egui_plot * Make `egui_plot::PlotMemory` public [#3871](emilk/egui#3871) #### egui * Selectable text in Labels [#3814](emilk/egui#3814) * `ComboBox`: add builder method for height [#3001](emilk/egui#3001) (thanks [@hinto-janai](https://github.com/hinto-janai)!) * Add keys `?`, `/`, `|` [#3820](emilk/egui#3820) * Fix clickable widgets blocking scrolling on touch screens [#3815](emilk/egui#3815) (thanks [@lucasmerlin](https://github.com/lucasmerlin)!) * Fix `stable_dt` [#3832](emilk/egui#3832) * Bug Fix : `Response::is_pointer_button_down_on` is now false the frame the button is released [#3833](emilk/egui#3833) (thanks [@rustbasic](https://github.com/rustbasic)!) * Use runtime knowledge of OS for OS-specific text editing [#3840](emilk/egui#3840) * Refactor: move text selection logic to own module [#3843](emilk/egui#3843) * Fix: dragging to above/below a `TextEdit` or `Label` will select text to begin/end [#3858](emilk/egui#3858) * Add `Response::contains_pointer` [#3859](emilk/egui#3859) * Always set `response.hovered` to false when dragging another widget [#3860](emilk/egui#3860) * Add `Align2::anchor_size` [#3863](emilk/egui#3863) * Add `Context::debug_text` [#3864](emilk/egui#3864) #### epaint * Add `Align2::anchor_size` [#3863](emilk/egui#3863) ### Checklist * [x] I have read and agree to [Contributor Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and the [Code of Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md) * [x] I've included a screenshot or gif (if applicable) * [x] I have tested the web demo (if applicable): * Using newly built examples: [app.rerun.io](https://app.rerun.io/pr/4885/index.html) * Using examples from latest `main` build: [app.rerun.io](https://app.rerun.io/pr/4885/index.html?manifest_url=https://app.rerun.io/version/main/examples_manifest.json) * Using full set of examples from `nightly` build: [app.rerun.io](https://app.rerun.io/pr/4885/index.html?manifest_url=https://app.rerun.io/version/nightly/examples_manifest.json) * [x] The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG - [PR Build Summary](https://build.rerun.io/pr/4885) - [Docs preview](https://rerun.io/preview/eb1bce846c3adb29b99d04018b002475994ad213/docs)  - [Examples preview](https://rerun.io/preview/eb1bce846c3adb29b99d04018b002475994ad213/examples)  - [Recent benchmark results](https://build.rerun.io/graphs/crates.html) - [Wasm size tracking](https://build.rerun.io/graphs/sizes.html) --------- Co-authored-by: Andreas Reich <r_andreas2@web.de>

Based on emilk/egui#3824

* feat: wasm32 autobuild now builds webgl fallback binary as well * feat: add feature detection for secure context and Firefox private browsing * fix: fix panic when `handle.requestPermission()` method doesn't exist * fix: use `__FILE_SYSTEM_TOOLS__.parseHandle` if it exists * fix: update the trunk URL in the build workflow * fix: fix `request_permission` binding being broken in Chromium * merge: update eframe and egui-wgpu from 0.24.1 to 0.25.0 * chore: update egui, catppuccin-egui and other egui-related crates * chore: fix update-induced compilation errors * chore: clippy * merge: update wgpu to 0.19 Based on emilk/egui#3824 * chore: fix more update-induced errors * chore: remove DX12 push constants workaround (fixed in wgpu 0.19) * feat: web build now has WebGPU and WebGL support in one binary * fix: make eframe's secure context check use worker context * chore: write upstream eframe and egui-wgpu version as 0.25.0 Chances are when the wgpu update changes land into a stable release of egui, they're going to use a squash merge, so we have no choice but to use commits from the egui master branch as the base commits for merges. * chore: update Trunk to latest version * chore: remove unnecessary dependency on glow * chore: remove assets/webgpu-test-worker.js * refactor: use relative public path This allows easily serving Luminol web builds under any path (e.g. https://example.com/luminol/ instead of https://example.com/).

Wumpf added 5 commits January 11, 2024 15:31

update to wgpu bleeding edge

f8c3154

add wgpu-with-webgl-fallback feature

ba99680

web fixup

828ddec

Use wgpu from main and make setting the window safe (and provide an u…

5297bc2

…nsafe variant)

Remove wgpu-with-webgl-fallback again

1871ffe

emilk commented Jan 15, 2024

View reviewed changes

Cargo.toml Outdated Show resolved Hide resolved

egui_demo_app_3.exe Outdated Show resolved Hide resolved

crates/egui_demo_app/Cargo.toml Show resolved Hide resolved

emilk mentioned this pull request Jan 15, 2024

WebGPU build broken #3675

Closed

emilk added 2 commits January 15, 2024 17:41

Remove exe

5a5022f

Clean up Cargo.toml

5d754c8

torokati44 mentioned this pull request Jan 16, 2024

wgpu: Update wgpu and naga to 0.19 ruffle-rs/ruffle#14682

Merged

3 tasks

emilk added 3 commits January 16, 2024 09:31

In eframe, document the need to turn on webgl/webgpu features of wgpu

404a95a

Improve docs of egui-wgpu

9e6b6ae

Fix doc-tests

84f351d

Wumpf reviewed Jan 16, 2024

View reviewed changes

crates/eframe/Cargo.toml Outdated Show resolved Hide resolved

update wgpu and wasm-bindgen

ce84ec1

emilk force-pushed the wgpu-update branch from b8871ed to ce84ec1 Compare January 18, 2024 10:04

emilk added 4 commits January 18, 2024 13:19

Update to raw-window-handle 0.6 (except for glow, stuck at 0.5)

cd2f6e0

Make winit a workspace dependency

4c7540f

Don't use deprecated methods of new raw-window-handle

ebba9f5

Fix web build

9c212c3

emilk added eframe Relates to epi and eframe egui-wgpu labels Jan 18, 2024

emilk added 4 commits January 18, 2024 14:17

rwh fixes

ccb9dc8

Nicer output from check.sh

8e16563

linux build fix

b18d4b2

cleanup

3840a84

emilk marked this pull request as ready for review January 18, 2024 13:47

emilk added 3 commits January 18, 2024 16:10

Web logger: Mute debug log-spam from wgpu crates

6b0c20b

List selected and available adapters in the egui_demo_app backend panel

90d7524

Remove "drag-to-move-window" demo from egui_demo_app

08fcca4

custom_window_frame is a better demo

fix typo

e996df6

We cannot list available adapters on web

7e66aa5

torokati44 reviewed Jan 18, 2024

View reviewed changes

crates/egui-wgpu/src/lib.rs Outdated Show resolved Hide resolved

emilk added 2 commits January 18, 2024 16:45

Warn about the 0.0.0.0 footgun

9b21cde

typo

5ae0072

Dinnerbone reviewed Jan 18, 2024

View reviewed changes

crates/eframe/src/web/web_painter_wgpu.rs Outdated Show resolved Hide resolved

emilk added 2 commits January 19, 2024 08:56

check window.isSecureContext and print info when not secure

70bec10

Explain how to opt-out of WebGPU

676cbb9

Mingun reviewed Jan 19, 2024

View reviewed changes

crates/eframe/src/web/web_painter_wgpu.rs Outdated Show resolved Hide resolved

emilk and others added 7 commits January 19, 2024 09:07

Use get_default_config on web

2421a62

typo

1b110e9

Co-authored-by: Mingun <Alexander_Sergey@mail.ru>

Use get_default_config on native

5fa9794

Better docs on how to pick WebGL and/or WebGPU

5ce6c66

fix web build

a329f83

Add 'WebGPU' to list of known words in clippy.toml

f71ba2b

Clippy fix

d97c8df

emilk merged commit b766a48 into master Jan 19, 2024
35 checks passed

emilk deleted the wgpu-update branch January 19, 2024 09:14

cwfitzgerald reviewed Jan 21, 2024

View reviewed changes

emilk mentioned this pull request Jan 23, 2024

Update to wgpu 0.19 and latest egui trunk rerun-io/rerun#4885

Merged

5 tasks

white-axe added a commit to white-axe/Luminol that referenced this pull request Jan 31, 2024

merge: update wgpu to 0.19

b861315

Based on emilk/egui#3824

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update wgpu to 0.19 #3824

Update wgpu to 0.19 #3824

emilk commented Jan 15, 2024 •

edited

emilk commented Jan 15, 2024

emilk commented Jan 18, 2024

torokati44 commented Jan 18, 2024

emilk commented Jan 18, 2024 •

edited

Wumpf commented Jan 18, 2024

Wumpf commented Jan 18, 2024 •

edited

emilk commented Jan 18, 2024

cwfitzgerald Jan 21, 2024

emilk Jan 23, 2024

emilk Jan 23, 2024

Update wgpu to 0.19 #3824

Update wgpu to 0.19 #3824

Conversation

emilk commented Jan 15, 2024 • edited

emilk commented Jan 15, 2024

emilk commented Jan 18, 2024

torokati44 commented Jan 18, 2024

emilk commented Jan 18, 2024 • edited

Wumpf commented Jan 18, 2024

Wumpf commented Jan 18, 2024 • edited

emilk commented Jan 18, 2024

cwfitzgerald Jan 21, 2024

Choose a reason for hiding this comment

emilk Jan 23, 2024

Choose a reason for hiding this comment

emilk Jan 23, 2024

Choose a reason for hiding this comment

emilk commented Jan 15, 2024 •

edited

emilk commented Jan 18, 2024 •

edited

Wumpf commented Jan 18, 2024 •

edited