Allow read access to shapes added to painter this frame #3866
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emilk
requested changes
Jan 23, 2024
|
Thanks for the PR! I have a few ideas for improvements |
suggested by emilk Co-authored-by: Emil Ernerfeldt <emil.ernerfeldt@gmail.com>
…o ::get, PaintList::all_entries returns Iterator<&ClippedShape>
|
All improvements requested so far are applied. |
emilk
approved these changes
Jan 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
I'm interested in exporting a picture drawn by egui as a vector graphic and thus need access to the picture's shapes.
Notes on the submitted code:
Ideally i would want to return the result iterator of
PaintList::all_entriesto the user. This however failed because of the required lifetimes.I was unsure wether to use
Context::graphics_mutinstead of creatingContext::graphicsandGraphicLayers::existing_list. Given thatContexthas a mutable and immutable version of these "getters" for other data, i feel it is more consistent to do it this way.