Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

If WebGPU fails, re-try adapter creation with WebGL #3895

Merged
merged 5 commits into from
Jan 29, 2024
Merged

If WebGPU fails, re-try adapter creation with WebGL #3895

merged 5 commits into from
Jan 29, 2024
+68 −10

Conversation

Wumpf
Copy link
Collaborator

@Wumpf Wumpf commented Jan 26, 2024

Draft until fully confirmed this works on Linux Chrome

@emilk emilk marked this pull request as draft January 26, 2024 11:22
emilk
emilk reviewed Jan 26, 2024
View reviewed changes
crates/eframe/src/web/web_painter_wgpu.rs Outdated Show resolved Hide resolved
crates/eframe/src/web/web_painter_wgpu.rs Outdated Show resolved Hide resolved
@Wumpf Wumpf added bug Something is broken web Related to running Egui on the web egui-wgpu labels Jan 26, 2024
@Wumpf Wumpf marked this pull request as ready for review January 26, 2024 16:56
@Wumpf Wumpf requested a review from emilk January 26, 2024 16:56
@Wumpf
Copy link
Collaborator Author

Wumpf commented Jan 26, 2024

confirmed working now by @jleibs

@Wumpf Wumpf mentioned this pull request Jan 28, 2024
Open
@emilk emilk merged commit 40ed503 into master Jan 29, 2024
38 checks passed
@emilk emilk deleted the webgpu-automatic-fallbacks branch January 29, 2024 10:04
@emilk emilk changed the title Re-try adapter creation if creation with WebGPU enabled fails and WebGL was enabled. If WebGPU fails, re-try adapter creation with WebGL Feb 5, 2024
@Wumpf Wumpf mentioned this pull request Mar 3, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emilk emilk Awaiting requested review from emilk

Assignees
No one assigned
Labels
bug Something is broken egui-wgpu web Related to running Egui on the web
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

app.rerun.io won't load in chrome on linux on latest main
2 participants
@Wumpf @emilk