Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

app.rerun.io won't load in chrome on linux on latest main #4915

Closed
jleibs opened this issue Jan 25, 2024 · 6 comments · Fixed by emilk/egui#3895
Closed

app.rerun.io won't load in chrome on linux on latest main #4915

jleibs opened this issue Jan 25, 2024 · 6 comments · Fixed by emilk/egui#3895
Assignees
Labels
🪳 bug Something isn't working 🐧 linux Linux-specific problems 🔺 re_renderer affects re_renderer itself 🦟 regression A thing that used to work in an earlier release 🕸️ web regarding running the viewer in a browser
Milestone

Comments

@jleibs
Copy link
Member

jleibs commented Jan 25, 2024

The egui update from #4885 appears to have caused a regression.

On attempted load, all I get is:
image

An error occurred during loading:
Failed to create wgpu adapter, no suitable adapter found.
Make sure you use a modern browser with either WebGL or WebGPU support enabled.

The problem does not appear to impact firefox, so something about chrome, specifically is confused.

Confirmed broken on Ubuntu 22.10.

Chrome thinks it has webgl support:
image

Output of console log:
image

@jleibs jleibs added 🪳 bug Something isn't working 👀 needs triage This issue needs to be triaged by the Rerun team 🦟 regression A thing that used to work in an earlier release 🐧 linux Linux-specific problems 🕸️ web regarding running the viewer in a browser and removed 👀 needs triage This issue needs to be triaged by the Rerun team labels Jan 25, 2024
@jleibs jleibs added this to the 0.13 milestone Jan 25, 2024
@jleibs jleibs changed the title app.rerun.io won't load in chrome on linux app.rerun.io won't load in chrome on linux on latest main Jan 25, 2024
@emilk emilk added the 🔺 re_renderer affects re_renderer itself label Jan 26, 2024
@emilk
Copy link
Member

emilk commented Jan 26, 2024

It works on Brave on macOS, chromium 121.0.6167.85

@Wumpf
Copy link
Member

Wumpf commented Jan 26, 2024

Related to

According to log we try to run with WebGPU, but that's behind a feature flag on Linux and afaik not actually really supported yet
https://github.com/gpuweb/gpuweb/wiki/Implementation-Status#chromium-chrome-edge-etc
Question now is ofc if you have this feature flag enabled, if not we should automatically use webgl on Linux Chrome unless explicitly specified otherwise. It's very strange that your browser reports "WebGPU" disabled and we go with it anyways!

Firefox works just nicely for you because in firefox (javascript) navigator.gpu is undefined thus we always pick webgl.

@emilk
Copy link
Member

emilk commented Jan 26, 2024

Adding special-casing based on User-Agent or similar seems like a bad route to go down.

image

How can we read the flag in the client? Can we?

@Wumpf
Copy link
Member

Wumpf commented Jan 26, 2024

I'd be surprised if we can, but need to have a closer look. The recommended way to check for webgpu support is to check navigator.gpu. Just repro'ed the issue as-is in a relatively fresh ubuntu VM with a freshly installed chrome. navigator.gpu is defined in the console just as expected (and kinda wrong) without setting any particular flags on the browser
I'll prod a bit around if we can do better than user-agent

@Wumpf Wumpf self-assigned this Jan 26, 2024
@Wumpf
Copy link
Member

Wumpf commented Jan 26, 2024

Looks like we can do an automatic retry with WebGL :)
Might need changes to egui though

@emilk
Copy link
Member

emilk commented Jan 26, 2024

Automatic retry sounds awesome!

emilk pushed a commit to emilk/egui that referenced this issue Jan 29, 2024
…GL was enabled. (#3895)

* Filed this in relation to the changes here
gfx-rs/wgpu#5142
* Fixes rerun-io/rerun#4915

Draft until fully confirmed this works on Linux Chrome
hacknus pushed a commit to hacknus/egui that referenced this issue Oct 30, 2024
…GL was enabled. (emilk#3895)

* Filed this in relation to the changes here
gfx-rs/wgpu#5142
* Fixes rerun-io/rerun#4915

Draft until fully confirmed this works on Linux Chrome
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🪳 bug Something isn't working 🐧 linux Linux-specific problems 🔺 re_renderer affects re_renderer itself 🦟 regression A thing that used to work in an earlier release 🕸️ web regarding running the viewer in a browser
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants