Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Much more accurate cpu_usage timing #3913

Merged
merged 1 commit into from Jan 29, 2024
Merged

Conversation

emilk
Copy link
Owner

@emilk emilk commented Jan 29, 2024

frame.info.cpu_usage now includes time for tessellation and rendering, but excludes vsync and context switching.

@emilk emilk added this to the Next Major Release milestone Jan 29, 2024
@emilk emilk added the eframe Relates to epi and eframe label Jan 29, 2024
@emilk emilk force-pushed the emilk/more-accurate-cpu-usage branch from 7ac72d2 to 0ff00d9 Compare January 29, 2024 17:40
@emilk emilk changed the title Make frame.info.cpu_usage take more into account Much more accurate cpu_usage timing Jan 29, 2024
@emilk emilk marked this pull request as ready for review January 29, 2024 17:45
@emilk emilk force-pushed the emilk/more-accurate-cpu-usage branch from 0ff00d9 to da2ffb7 Compare January 29, 2024 17:46
@emilk emilk merged commit ab39420 into master Jan 29, 2024
35 checks passed
@emilk emilk deleted the emilk/more-accurate-cpu-usage branch January 29, 2024 18:12
emilk added a commit to rerun-io/rerun that referenced this pull request Jan 30, 2024
### What
This got more accurate in emilk/egui#3913

### Checklist
* [x] I have read and agree to [Contributor
Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and
the [Code of
Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md)
* [x] I've included a screenshot or gif (if applicable)
* [x] I have tested the web demo (if applicable):
* Using newly built examples:
[app.rerun.io](https://app.rerun.io/pr/4951/index.html)
* Using examples from latest `main` build:
[app.rerun.io](https://app.rerun.io/pr/4951/index.html?manifest_url=https://app.rerun.io/version/main/examples_manifest.json)
* Using full set of examples from `nightly` build:
[app.rerun.io](https://app.rerun.io/pr/4951/index.html?manifest_url=https://app.rerun.io/version/nightly/examples_manifest.json)
* [x] The PR title and labels are set such as to maximize their
usefulness for the next release's CHANGELOG

- [PR Build Summary](https://build.rerun.io/pr/4951)
- [Docs
preview](https://rerun.io/preview/4a12c750840ffa02ba0ea1ca710d00367336144b/docs)
<!--DOCS-PREVIEW-->
- [Examples
preview](https://rerun.io/preview/4a12c750840ffa02ba0ea1ca710d00367336144b/examples)
<!--EXAMPLES-PREVIEW-->
- [Recent benchmark results](https://build.rerun.io/graphs/crates.html)
- [Wasm size tracking](https://build.rerun.io/graphs/sizes.html)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
eframe Relates to epi and eframe
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant