Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added unhovered style, For TextEdit used bg_stroke in unhovered. #4120

Closed
wants to merge 12 commits into from

Conversation

rustbasic
Copy link
Contributor

Added unhovered style,
For TextEdit used bg_stroke in unhovered.

@emilk
Copy link
Owner

emilk commented Mar 12, 2024

explain why, preferably with an image

@rustbasic
Copy link
Contributor Author

rustbasic commented Mar 12, 2024

explain why, preferably with an image

It is good to have a border visible even when the input area is not in focus or unhovered.

( Related to slider is part of #4092. )

Below is a screen with two TextEdits applied.

explain20240312

Below is a screen without applied.

explain20240313-1

@@ -1051,6 +1054,9 @@ pub struct Widgets {
/// The style of an interactive widget, such as a button, at rest.
pub inactive: WidgetVisuals,

/// The style of a unhovered widget.
pub unhovered: WidgetVisuals,
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That is what inactive means.

@emilk
Copy link
Owner

emilk commented Mar 25, 2024

I think there is a misunderstanding here. inactive is already used for things that aren't hovered.

@emilk emilk closed this Mar 25, 2024
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants