Expose state override for HeaderResponse
#4200
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
May be, If you upvote this, we could save few man-years #4181 |
emilk
approved these changes
Mar 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm trying to create some custom collapsing headers that add additional buttons inside the header itself. Because of this, I load the
CollapsingStatein my special widget manually. But becauseHeaderResponseowns theUiand theCollapsingState, there is no way for me to open/close the collapsing header based on response of the inner widget.Initially, I considered just exposing
statemember ofHeaderResponse, but that exposes too much of the API at the wrong time, in my opinion.So instead I found it'd be safer to just expose the open/close API to the response itself, and that's what this PR does.