Fix unintentional value retain #248
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To quote to the documentation of parameters (https://docs.racket-lang.org/reference/parameters.html), > as far as the memory manager is concerned, > the value originally associated with a parameter through parameterize > remains reachable as long the continuation is reachable, > even if the parameter is mutated. The parameter current-terms is initialized and/or parameterized to a strong hash, making it not possible to GC the hash. This PR fixes the issue by initializing and/or parameterizing to #f first, and then mutates the parameter to a desired value later. Fixes emina#247
|
By the way, thanks to @rocketnia who pointed me to the parameter caveat! |
|
Glad it worked out! 😄 |
|
Great catch; thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To quote to the documentation of parameters
(https://docs.racket-lang.org/reference/parameters.html),
The parameter current-terms is initialized and/or parameterized to a strong hash, making it not possible to GC the hash. This PR fixes the issue by initializing and/or parameterizing to #f first, and then mutates the parameter to a desired value later.
Fixes #247