Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added chunking for gossip unicast #254

Merged
merged 1 commit into from
Jun 15, 2019
Merged

Added chunking for gossip unicast #254

merged 1 commit into from
Jun 15, 2019

Conversation

kelindar
Copy link
Contributor

This adds chunking before sending through to the gossi unicast, given that the max frame is 10MB we can send at once.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.02%) to 90.531% when pulling 355838e on feat-frame into 5657391 on master.

@kelindar kelindar self-assigned this Jun 15, 2019
@kelindar kelindar requested a review from Florimond June 15, 2019 08:08
Florimond
Florimond approved these changes Jun 15, 2019
View reviewed changes
Copy link
Member

@Florimond Florimond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Florimond Florimond merged commit f660e64 into master Jun 15, 2019
@delete-merged-branch delete-merged-branch bot deleted the feat-frame branch June 15, 2019 14:20
Florimond pushed a commit that referenced this pull request Sep 7, 2023
@Florimond
Added chunking for gossip unicast (#254)
784f621
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Florimond Florimond Florimond approved these changes

Assignees

@kelindar kelindar

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kelindar @coveralls @Florimond