Various Non-Breaking Enhancements #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added .editorconfig with settings that match the majority of the codebase, fixed diversions where appropriate.
1. The public methods are now all fluent, so you can chain method calls: `emitter.me().subscribe(EmitterEvents.me, me => console.log(me))` etc. 2. The internal utility methods now appear at the bottom of the class definition, making it a bit easier to understand the implementation. 3. A event enumeration is now exposed, making it possible to use strong typing for the `on` method, as well as the new `off` method. 4. Added `off` to make event removal possible. 5. Added support for multiple callbacks per event. 6. Renamed the internal method logError to _throwError to better describe what it does. 7. Updated the `on` parameter check to accurately describe all possible events (calculated from the new enum so it doesn’t go out of style easily again) 8. Made consistent usage of double quotes across the file, which seemed to be the predominant pattern in place already. 9. Made other minor consistency fixes with whitespace.
|
I thought I'd contribute some of the tweaks I believe would make the JS library a bit more useful, and cleaned some stuff up while I was in there. Let me know if this is too aggressive of a pull request, and I can dial back any and/or all changes. I also have a Angular TypeScript version I could provide, but I suspect that'd merit a new repository. |
kelindar
approved these changes
Dec 18, 2018
|
Looks great! Thanks for the PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
emitter.me().subscribe(EmitterEvents.me, me => console.log(me))etc.onmethod, as well as the newoffmethod.offto make event removal possible.onparameter check to accurately describe all possible events (calculated from the new enum so it doesn’t go out of style easily again)