Add SPI support for MS5611 driver #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
staroselskii
suggested changes
Feb 26, 2018
Python/navio/ms5611.py
Outdated
| self.bus.max_speed_hz=1000000 | ||
|
|
||
|
|
||
| def WriteReg(self, reg_address, data = 0x00): |
Python/navio/ms5611.py
Outdated
| self.bus.close() | ||
| return rx | ||
|
|
||
| def ReadRegs(self, reg_address, length=3): |
Python/navio/ms5611.py
Outdated
|
|
||
| class MS5611: | ||
|
|
||
| class SPI_interface(): |
Python/navio/ms5611.py
Outdated
| return rx[1:len(rx)] | ||
|
|
||
|
|
||
| class I2C_interface(): |
Python/navio/ms5611.py
Outdated
| self.bus = SMBus(i2c_bus_number) | ||
| self.address = address | ||
|
|
||
| def WriteReg(self, reg_address, device_address = None): |
IgorAnohin
force-pushed
the
pr-update-ms5611-driver
branch
from
6e977e7
to
4819f01
Compare
|
I think, that now names more valid |
staroselskii
approved these changes
Feb 26, 2018
IgorAnohin
force-pushed
the
pr-update-ms5611-driver
branch
from
4819f01
to
9173c07
Compare
|
I think, that 'device' - better name for SPI and I2C, than flag. |
IgorAnohin
force-pushed
the
pr-update-ms5611-driver
branch
from
9173c07
to
2418cd4
Compare
Add SPI support
IgorAnohin
force-pushed
the
pr-update-ms5611-driver
branch
from
2418cd4
to
9608e4f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello!
I added SPI support for MS5611.